public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Florian Mickler <florian@mickler.org>
Cc: Jeff Mahoney <jeffm@suse.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	balbir@linux.vnet.ibm.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] taskstats: Use better ifdef for alignment
Date: Sat, 1 Jan 2011 19:51:35 +0300	[thread overview]
Message-ID: <20110101165135.GJ1886@bicker> (raw)
In-Reply-To: <20110101171946.6179c3b6@schatten.dmk.lab>

On Sat, Jan 01, 2011 at 05:19:46PM +0100, Florian Mickler wrote:
> Is there already a patch available or integrated into iotop which
> fixes this? I'd think that if the kernel could wait on fixed iotop's to
> be distributed it would be easier to sell the breakage on bugzilla &
> co...
> 

The story is that 4be2c95d1f "taskstats: pad taskstats netlink response
for aligment issues on ia64" broke iotop on 64 bit processors (32 bit
was unaffected).  This patch fixes it for x86-64 and powerpc-64.

On the other 64 bit processors iotop works but instead you get a message
in dmesg:
kernel unaligned access to 0xe000023879dca9bc, ip=0xa000000100133d10

So on those arches you were already getting posts to bugzilla etc.  Now
those people can upgrade the kernel and download iotop version 0.4.2 or
higher.

regards,
dan carpenter


  reply	other threads:[~2011-01-01 16:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30  0:12 [PATCH] taskstats: Use better ifdef for alignment Jeff Mahoney
2010-12-30  0:14 ` Andrew Morton
2010-12-30  5:26   ` Jeff Mahoney
2010-12-30  5:32     ` Andrew Morton
2010-12-30 15:52       ` Jeff Mahoney
2011-01-01 16:19         ` Florian Mickler
2011-01-01 16:51           ` Dan Carpenter [this message]
2011-01-02 12:17             ` Florian Mickler
2011-01-08 22:42               ` Florian Mickler
2011-01-08 22:46               ` Jeff Mahoney
2010-12-31  0:23 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110101165135.GJ1886@bicker \
    --to=error27@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=davem@davemloft.net \
    --cc=florian@mickler.org \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox