* [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()
@ 2010-12-31 15:26 roel kluin
2011-01-02 12:37 ` Mark Brown
2011-01-04 20:51 ` Liam Girdwood
0 siblings, 2 replies; 3+ messages in thread
From: roel kluin @ 2010-12-31 15:26 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Andrew Morton, LKML
The index is missing so the return is wrong.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/regulator/isl6271a-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/isl6271a-regulator.c b/drivers/regulator/isl6271a-regulator.c
index b8cc638..13e2073 100644
--- a/drivers/regulator/isl6271a-regulator.c
+++ b/drivers/regulator/isl6271a-regulator.c
@@ -169,7 +169,7 @@ static int __devinit isl6271a_probe(struct i2c_client *i2c,
init_data, pmic);
if (IS_ERR(pmic->rdev[i])) {
dev_err(&i2c->dev, "failed to register %s\n", id->name);
- err = PTR_ERR(pmic->rdev);
+ err = PTR_ERR(pmic->rdev[i]);
goto error;
}
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()
2010-12-31 15:26 [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe() roel kluin
@ 2011-01-02 12:37 ` Mark Brown
2011-01-04 20:51 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-01-02 12:37 UTC (permalink / raw)
To: roel kluin; +Cc: Liam Girdwood, Andrew Morton, LKML
On Fri, Dec 31, 2010 at 04:26:47PM +0100, roel kluin wrote:
> The index is missing so the return is wrong.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe()
2010-12-31 15:26 [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe() roel kluin
2011-01-02 12:37 ` Mark Brown
@ 2011-01-04 20:51 ` Liam Girdwood
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-01-04 20:51 UTC (permalink / raw)
To: roel kluin; +Cc: Mark Brown, Andrew Morton, LKML
On Fri, 2010-12-31 at 16:26 +0100, roel kluin wrote:
> The index is missing so the return is wrong.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> drivers/regulator/isl6271a-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-04 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-31 15:26 [PATCH] regulator: missing index in PTR_ERR() in isl6271a_probe() roel kluin
2011-01-02 12:37 ` Mark Brown
2011-01-04 20:51 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox