Re: [PATCH] gpio/ml_ioh_gpio: ML7213 GPIO driver

Tomoya MORINAGA
2011-01-05T05:24:25Z

Hi Andrew,

On Tuesday, January 04, 2011 6:40 AM, Andrew Morton wrote:
>> + for (i = 0, chip = chip_save; i < 8; i++, chip++) {
>
> chip = chip_save;
> for (i = 0; i < 8; i++, chip++) {
>
> is simpler, and simpler is better.

I will modify and post the patch soon.

>> + ret = gpiochip_add(&chip->gpio);
>> + if (ret) {
>> + dev_err(&pdev->dev, "IOH gpio: Failed to register GPIO\n");
>> + goto err_gpiochip_add;
>
> Here we should run gpiochip_remove() against chips 0 .. i-1, no?

Yes, you are right.
I will modify and post the patch soon.

Thanks,,
---
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.