From: Don Zickus <dzickus@redhat.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org, 599368@bugs.debian.org,
608138@bugs.debian.org, Cesare Leonardi <celeonar@gmail.com>
Subject: Re: [PATCH v2] watchdog: Improve initialisation error message and documentation
Date: Mon, 3 Jan 2011 08:56:02 -0500 [thread overview]
Message-ID: <20110103135602.GO3743@redhat.com> (raw)
In-Reply-To: <1294009362.3167.126.camel@localhost>
On Sun, Jan 02, 2011 at 11:02:42PM +0000, Ben Hutchings wrote:
> The error message 'NMI watchdog failed to create perf event...' does
> not make it clear that this is a fatal error for the watchdog. It
> also currently prints the error value as a pointer, rather than
> extracting the error code with PTR_ERR(). Fix that.
>
> Add a note to the description of the 'nowatchdog' kernel parameter to
> associate it with this message.
>
> Reported-by: Cesare Leonardi <celeonar@gmail.com>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Looks good, thanks. I'll add it to my queue.
Cheers,
Don
prev parent reply other threads:[~2011-01-03 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 22:00 [PATCH] watchdog: Improve failure message and documentation Ben Hutchings
2011-01-02 23:02 ` [PATCH v2] watchdog: Improve initialisation error " Ben Hutchings
2011-01-03 13:56 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110103135602.GO3743@redhat.com \
--to=dzickus@redhat.com \
--cc=599368@bugs.debian.org \
--cc=608138@bugs.debian.org \
--cc=ben@decadent.org.uk \
--cc=celeonar@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox