* [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
@ 2011-01-03 15:57 Axel Lin
2011-01-03 15:59 ` Mark Brown
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Axel Lin @ 2011-01-03 15:57 UTC (permalink / raw)
To: linux-kernel; +Cc: Yong Shen, Liam Girdwood, Mark Brown
Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/mc13892-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index 16a0532..1b8f739 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -550,7 +550,7 @@ static int __devinit mc13892_regulator_probe(struct platform_device *pdev)
if (ret)
goto err_free;
- mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
+ ret = mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
MC13892_SWITCHERS5_SW3MODE_M |
MC13892_SWITCHERS5_SW4MODE_M,
MC13892_SWITCHERS5_SW3MODE_AUTO |
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
2011-01-03 15:57 [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret Axel Lin
@ 2011-01-03 15:59 ` Mark Brown
2011-01-04 2:02 ` Yong Shen
2011-01-04 20:51 ` Liam Girdwood
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-01-03 15:59 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Yong Shen, Liam Girdwood
On Mon, Jan 03, 2011 at 11:57:38PM +0800, Axel Lin wrote:
> Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
2011-01-03 15:57 [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret Axel Lin
2011-01-03 15:59 ` Mark Brown
@ 2011-01-04 2:02 ` Yong Shen
2011-01-04 20:51 ` Liam Girdwood
2 siblings, 0 replies; 4+ messages in thread
From: Yong Shen @ 2011-01-04 2:02 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Liam Girdwood, Mark Brown
Acked-by: Yong Shen <yong.shen@linaro.org>
On Mon, Jan 3, 2011 at 11:57 PM, Axel Lin <axel.lin@gmail.com> wrote:
> Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/regulator/mc13892-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
> index 16a0532..1b8f739 100644
> --- a/drivers/regulator/mc13892-regulator.c
> +++ b/drivers/regulator/mc13892-regulator.c
> @@ -550,7 +550,7 @@ static int __devinit mc13892_regulator_probe(struct platform_device *pdev)
> if (ret)
> goto err_free;
>
> - mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
> + ret = mc13xxx_reg_rmw(mc13892, MC13892_SWITCHERS5,
> MC13892_SWITCHERS5_SW3MODE_M |
> MC13892_SWITCHERS5_SW4MODE_M,
> MC13892_SWITCHERS5_SW3MODE_AUTO |
> --
> 1.7.0.4
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret
2011-01-03 15:57 [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret Axel Lin
2011-01-03 15:59 ` Mark Brown
2011-01-04 2:02 ` Yong Shen
@ 2011-01-04 20:51 ` Liam Girdwood
2 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-01-04 20:51 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Yong Shen, Mark Brown
On Mon, 2011-01-03 at 23:57 +0800, Axel Lin wrote:
> Otherwise, we will not return error if write to MC13892_SWITCHERS5 failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/regulator/mc13892-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-04 20:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-03 15:57 [PATCH] regulator: Assign return value of mc13xxx_reg_rmw to ret Axel Lin
2011-01-03 15:59 ` Mark Brown
2011-01-04 2:02 ` Yong Shen
2011-01-04 20:51 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox