From: Randy Dunlap <randy.dunlap@oracle.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Matt Turner <mattst88@gmail.com>,
Bob Tracy <rct@gherkin.frus.com>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
mcree@orcon.net.nz, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha
Date: Tue, 4 Jan 2011 14:11:51 -0800 [thread overview]
Message-ID: <20110104141151.b6035bf3.randy.dunlap@oracle.com> (raw)
In-Reply-To: <AANLkTikyX3F+NjHVTGVV6rKyJhZQCcb3150-91La0rHs@mail.gmail.com>
On Tue, 4 Jan 2011 22:56:18 +0200 Pekka Enberg wrote:
> On Tue, Jan 4, 2011 at 9:37 PM, Matt Turner <mattst88@gmail.com> wrote:
> > On Tue, Jan 4, 2011 at 1:18 AM, Bob Tracy <rct@gherkin.frus.com> wrote:
> >> Another 2.6.37-rc8 build failure on alpha:
> >>
> >> (...)
> >> CC [M] drivers/i2c/busses/i2c-i801.o
> >> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> >> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
> >> drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
> >> drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
> >> make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
> >> make[2]: *** [drivers/i2c/busses] Error 2
> >> make[1]: *** [drivers/i2c] Error 2
> >> make: *** [drivers] Error 2
> >>
> >> --Bob
> >
> > Is this specific to alpha? I wonder why we don't see this on other platforms?
>
> The x86 version of <asm/pci.h> includes <linux/slab.h> which hides the
> problem on x86 at least. There was a big cleanup of implicit
> <linux/slab.h> inclusions few months ago which has exposed the
> problem.
>
> It's a bug in the driver, just add the include there.
exactly.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts: http://www.xenotime.net/linux/recipes/
next prev parent reply other threads:[~2011-01-04 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 6:18 [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 7:15 ` Pekka Enberg
2011-01-04 19:37 ` Matt Turner
2011-01-04 20:56 ` Pekka Enberg
2011-01-04 22:11 ` Randy Dunlap [this message]
2011-01-10 4:44 ` [PATCH] i2c-i801: Add missing <linux/slab.h> include Michael Cree
2011-01-10 6:46 ` Pekka Enberg
2011-01-10 14:03 ` Bob Tracy
2011-01-04 22:04 ` [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha Bob Tracy
2011-01-04 21:10 ` Maciej Rutecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104141151.b6035bf3.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mcree@orcon.net.nz \
--cc=penberg@kernel.org \
--cc=rct@gherkin.frus.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox