From: Robert Richter <robert.richter@amd.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Stephane Eranian <eranian@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"paulus@samba.org" <paulus@samba.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"fweisbec@gmail.com" <fweisbec@gmail.com>,
"perfmon2-devel@lists.sf.net" <perfmon2-devel@lists.sf.net>,
"eranian@gmail.com" <eranian@gmail.com>
Subject: Re: [PATCH] perf: fix perf_event.h header usage
Date: Tue, 4 Jan 2011 17:47:37 +0100 [thread overview]
Message-ID: <20110104164737.GB4739@erda.amd.com> (raw)
In-Reply-To: <20110104154439.GA26167@ghostprotocols.net>
On 04.01.11 10:44:39, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jan 04, 2011 at 04:30:01PM +0200, Stephane Eranian escreveu:
> > This patch fixes the usage of the perf_event.h header file
> > between command modules and the supporting code in util.
> >
> > It is necessary to ensure that ALL files use the SAME
> > perf_event.h header from the kernel source tree.
> >
> > There were a couple of #include <linux/perf_event.h> mixed
> > with #include "../../perf_event.h".
> >
> > This caused issues on some distros because of mismatch
> > in the layout of struct perf_event_attr. That eventually
> > led perf stat to segfault.
> >
> > Signed-off-by: Stephane Eranian <eranian@google.com>
>
> Thanks, applying.
Isn't this valid for all <linux/*.h> header files?
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
next prev parent reply other threads:[~2011-01-04 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 14:30 [PATCH] perf: fix perf_event.h header usage Stephane Eranian
2011-01-04 15:44 ` Arnaldo Carvalho de Melo
2011-01-04 16:47 ` Robert Richter [this message]
2011-01-05 17:37 ` [tip:perf/core] perf tools: Fix " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104164737.GB4739@erda.amd.com \
--to=robert.richter@amd.com \
--cc=acme@redhat.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox