From: Greg KH <gregkh@suse.de>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH 0/2] Annotate gpio-configuration with __must_check
Date: Tue, 4 Jan 2011 12:27:18 -0800 [thread overview]
Message-ID: <20110104202718.GA31444@suse.de> (raw)
In-Reply-To: <1294159868-4989-1-git-send-email-w.sang@pengutronix.de>
On Tue, Jan 04, 2011 at 05:51:06PM +0100, Wolfram Sang wrote:
> Here is a small series generating a lot of warnings, especially in board
> bringup-files. Still, I think it is worthwhile to be strict about checking
> return values of gpio-configuration-functions. My suggestion to keep the noise
> a bit lower is to put it into linux-next for one cycle and then merge it for
> 2.6.39? That should give people some time to fix the issues in time. Looking
> forward to comments.
It's ok to add this type of thing, but please, go through and fix the
warnings at the same time. Otherwise it's a bit rude to force others to
fix their code for something that you did.
Care to also send those patches along?
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-04 20:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 16:51 [PATCH 0/2] Annotate gpio-configuration with __must_check Wolfram Sang
2011-01-04 16:51 ` [PATCH 1/2] gpiolib: annotate gpio-intialization " Wolfram Sang
2011-01-04 16:51 ` [PATCH 2/2] gpiolib: add missing functions to generic fallback Wolfram Sang
2011-01-04 20:27 ` Greg KH [this message]
2011-01-04 21:29 ` [PATCH 0/2] Annotate gpio-configuration with __must_check Wolfram Sang
2011-01-04 21:34 ` Greg KH
2011-01-04 23:05 ` Wolfram Sang
2011-01-04 23:44 ` Greg KH
2011-01-05 11:18 ` Mark Brown
2011-01-05 18:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104202718.GA31444@suse.de \
--to=gregkh@suse.de \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox