From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Ingo Molnar <mingo@elte.hu>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rcu: remove SPARSE_RCU_POINTER
Date: Tue, 4 Jan 2011 13:19:38 -0800 [thread overview]
Message-ID: <20110104211938.GT2026@linux.vnet.ibm.com> (raw)
In-Reply-To: <201101041136.02514.arnd@arndb.de>
On Tue, Jan 04, 2011 at 11:36:02AM +0100, Arnd Bergmann wrote:
> On Tuesday 04 January 2011 09:43:01 Lai Jiangshan wrote:
> > As I known, __rcu annotations do not effect the result compiled kernel.
> >
> > They work only when we use spare("make C=1" or "make C=2"),
> > So we don't need another new switch for it since we have one
> > for debugging(use spare or not).
> >
> > signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> The intention of this option was to avoid introducing an excessive
> number of false positives when using sparse.
>
> We should only make that unconditional if we are reasonably convinced
> that all the majority of warnings caused by it should actually
> lead to changes in the code.
I agree with Arnd here -- the changes required are extensive in many
cases, and a number of subsystems are making decent progress.
Thanx, Paul
next prev parent reply other threads:[~2011-01-04 21:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 8:43 [PATCH] rcu: remove SPARSE_RCU_POINTER Lai Jiangshan
2011-01-04 10:36 ` Arnd Bergmann
2011-01-04 21:19 ` Paul E. McKenney [this message]
2011-01-05 1:30 ` Lai Jiangshan
2011-01-06 5:59 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104211938.GT2026@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=arnd@arndb.de \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox