From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Neil Horman <nhorman@tuxdriver.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [RFC patch 2/5] trace event skb fix unassigned field
Date: Tue, 04 Jan 2011 18:16:31 -0500 [thread overview]
Message-ID: <20110104232419.267814584@efficios.com> (raw)
In-Reply-To: 20110104231629.996422888@efficios.com
[-- Attachment #1: trace-event-skb-fix-unassigned-field.patch --]
[-- Type: text/plain, Size: 985 bytes --]
The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
leaving its trace output as garbage. Assign the value to 0 when skb is NULL
instead.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Neil Horman <nhorman@tuxdriver.com>
CC: Thomas Gleixner <tglx@linutronix.de>
---
include/trace/events/skb.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: linux-2.6-lttng/include/trace/events/skb.h
===================================================================
--- linux-2.6-lttng.orig/include/trace/events/skb.h
+++ linux-2.6-lttng/include/trace/events/skb.h
@@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
TP_fast_assign(
__entry->skbaddr = skb;
- if (skb) {
- __entry->protocol = ntohs(skb->protocol);
- }
+ __entry->protocol = skb ? ntohs(skb->protocol) : 0;
__entry->location = location;
),
next prev parent reply other threads:[~2011-01-04 23:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:16 [RFC patch 0/5] Trace event fixes and cleanups Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 1/5] trace event block fix unassigned field Mathieu Desnoyers
2011-01-05 15:09 ` Jeff Moyer
2011-01-05 19:34 ` Mathieu Desnoyers
2011-01-05 19:57 ` Jeff Moyer
2011-01-04 23:16 ` Mathieu Desnoyers [this message]
2011-01-04 23:16 ` [RFC patch 3/5] ftrace trace event add missing semicolumn Mathieu Desnoyers
2011-01-05 0:00 ` Frederic Weisbecker
2011-01-05 0:18 ` Mathieu Desnoyers
2011-01-05 2:08 ` Frederic Weisbecker
2011-01-05 2:35 ` Mathieu Desnoyers
2011-01-05 2:58 ` Frederic Weisbecker
2011-01-05 13:52 ` Mathieu Desnoyers
2011-01-05 15:02 ` Frederic Weisbecker
2011-01-05 19:56 ` Mathieu Desnoyers
2011-01-05 23:40 ` Frederic Weisbecker
2011-01-05 23:57 ` Steven Rostedt
2011-01-06 18:08 ` Mathieu Desnoyers
2011-01-05 3:01 ` Valdis.Kletnieks
2011-01-05 3:10 ` Frederic Weisbecker
2011-01-05 6:37 ` Valdis.Kletnieks
2011-01-05 13:56 ` Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 4/5] tracepoint trace event add missing comma Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 5/5] trace event sched: remove TP_perf_assign Mathieu Desnoyers
2011-01-05 9:58 ` Peter Zijlstra
2011-01-05 13:28 ` Mathieu Desnoyers
[not found] <E1PaGZY-0001EI-BD@smtp.tuxdriver.com>
2011-01-04 23:54 ` [RFC patch 2/5] trace event skb fix unassigned field Frederic Weisbecker
2011-01-05 0:40 ` Mathieu Desnoyers
2011-01-05 0:49 ` Frederic Weisbecker
2011-01-05 1:21 ` Mathieu Desnoyers
2011-01-05 11:59 ` Neil Horman
2011-01-05 13:26 ` Mathieu Desnoyers
2011-01-06 0:01 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104232419.267814584@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox