From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [RFC patch 5/5] trace event sched: remove TP_perf_assign
Date: Tue, 04 Jan 2011 18:16:34 -0500 [thread overview]
Message-ID: <20110104232419.782205410@efficios.com> (raw)
In-Reply-To: 20110104231629.996422888@efficios.com
[-- Attachment #1: trace-event-sched-remove-perf-count.patch --]
[-- Type: text/plain, Size: 2128 bytes --]
The TP_perf_assign part of 2 scheduler TRACE_EVENT are not used and don't act as
TRACE_EVENT fields per se.
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Mike Galbraith <efault@gmx.de>
CC: Paul Mackerras <paulus@samba.org>
CC: Arnaldo Carvalho de Melo <acme@redhat.com>
---
include/trace/events/sched.h | 6 ------
include/trace/ftrace.h | 6 ------
2 files changed, 12 deletions(-)
Index: linux-2.6-lttng/include/trace/events/sched.h
===================================================================
--- linux-2.6-lttng.orig/include/trace/events/sched.h
+++ linux-2.6-lttng/include/trace/events/sched.h
@@ -294,9 +294,6 @@ DECLARE_EVENT_CLASS(sched_stat_template,
memcpy(__entry->comm, tsk->comm, TASK_COMM_LEN);
__entry->pid = tsk->pid;
__entry->delay = delay;
- )
- TP_perf_assign(
- __perf_count(delay);
),
TP_printk("comm=%s pid=%d delay=%Lu [ns]",
@@ -351,9 +348,6 @@ TRACE_EVENT(sched_stat_runtime,
__entry->pid = tsk->pid;
__entry->runtime = runtime;
__entry->vruntime = vruntime;
- )
- TP_perf_assign(
- __perf_count(runtime);
),
TP_printk("comm=%s pid=%d runtime=%Lu [ns] vruntime=%Lu [ns]",
Index: linux-2.6-lttng/include/trace/ftrace.h
===================================================================
--- linux-2.6-lttng.orig/include/trace/ftrace.h
+++ linux-2.6-lttng/include/trace/ftrace.h
@@ -481,9 +481,6 @@ static inline notrace int ftrace_get_off
#undef TP_fast_assign
#define TP_fast_assign(args...) args
-#undef TP_perf_assign
-#define TP_perf_assign(args...)
-
#undef DECLARE_EVENT_CLASS
#define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \
\
@@ -680,9 +677,6 @@ __attribute__((section("_ftrace_events")
#undef __perf_addr
#define __perf_addr(a) __addr = (a)
-#undef __perf_count
-#define __perf_count(c) __count = (c)
-
#undef DECLARE_EVENT_CLASS
#define DECLARE_EVENT_CLASS(call, proto, args, tstruct, assign, print) \
static notrace void \
next prev parent reply other threads:[~2011-01-04 23:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 23:16 [RFC patch 0/5] Trace event fixes and cleanups Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 1/5] trace event block fix unassigned field Mathieu Desnoyers
2011-01-05 15:09 ` Jeff Moyer
2011-01-05 19:34 ` Mathieu Desnoyers
2011-01-05 19:57 ` Jeff Moyer
2011-01-04 23:16 ` [RFC patch 2/5] trace event skb " Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 3/5] ftrace trace event add missing semicolumn Mathieu Desnoyers
2011-01-05 0:00 ` Frederic Weisbecker
2011-01-05 0:18 ` Mathieu Desnoyers
2011-01-05 2:08 ` Frederic Weisbecker
2011-01-05 2:35 ` Mathieu Desnoyers
2011-01-05 2:58 ` Frederic Weisbecker
2011-01-05 13:52 ` Mathieu Desnoyers
2011-01-05 15:02 ` Frederic Weisbecker
2011-01-05 19:56 ` Mathieu Desnoyers
2011-01-05 23:40 ` Frederic Weisbecker
2011-01-05 23:57 ` Steven Rostedt
2011-01-06 18:08 ` Mathieu Desnoyers
2011-01-05 3:01 ` Valdis.Kletnieks
2011-01-05 3:10 ` Frederic Weisbecker
2011-01-05 6:37 ` Valdis.Kletnieks
2011-01-05 13:56 ` Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 4/5] tracepoint trace event add missing comma Mathieu Desnoyers
2011-01-04 23:16 ` Mathieu Desnoyers [this message]
2011-01-05 9:58 ` [RFC patch 5/5] trace event sched: remove TP_perf_assign Peter Zijlstra
2011-01-05 13:28 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104232419.782205410@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox