From: Frederic Weisbecker <fweisbec@gmail.com>
To: "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC patch 2/5] trace event skb fix unassigned field
Date: Wed, 5 Jan 2011 00:54:21 +0100 [thread overview]
Message-ID: <20110104235418.GD2911@nowhere> (raw)
In-Reply-To: <E1PaGZY-0001EI-BD@smtp.tuxdriver.com>
On Tue, Jan 04, 2011 at 06:46:06PM -0500, nhorman@tuxdriver.com wrote:
> Acked- by: Neil Horman <nhorman@tuxdriver.com>
>
>
> Sent from my Verizon Wireless Phone
>
> ----- Reply message -----
> From: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Date: Tue, Jan 4, 2011 6:16 pm
> Subject: [RFC patch 2/5] trace event skb fix unassigned field
> To: "LKML" <linux-kernel@vger.kernel.org>
> Cc: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>, "Steven Rostedt" <rostedt@goodmis.org>, "Frederic Weisbecker" <fweisbec@gmail.com>, "Ingo Molnar" <mingo@elte.hu>, "Neil Horman" <nhorman@tuxdriver.com>, "Thomas Gleixner" <tglx@linutronix.de>
>
>
> The field "protocol" in event kfree_skb is left unassigned if skb is NULL,
> leaving its trace output as garbage. Assign the value to 0 when skb is NULL
> instead.
Hm, if the skb is already null, we probably shouldn't send any trace.
What about using TP_CONDITION() ?
>
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> CC: Steven Rostedt <rostedt@goodmis.org>
> CC: Frederic Weisbecker <fweisbec@gmail.com>
> CC: Ingo Molnar <mingo@elte.hu>
> CC: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Gleixner <tglx@linutronix.de>
> ---
> include/trace/events/skb.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> Index: linux-2.6-lttng/include/trace/events/skb.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/trace/events/skb.h
> +++ linux-2.6-lttng/include/trace/events/skb.h
> @@ -25,9 +25,7 @@ TRACE_EVENT(kfree_skb,
>
> TP_fast_assign(
> __entry->skbaddr = skb;
> - if (skb) {
> - __entry->protocol = ntohs(skb->protocol);
> - }
> + __entry->protocol = skb ? ntohs(skb->protocol) : 0;
> __entry->location = location;
> ),
>
>
>
next parent reply other threads:[~2011-01-04 23:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1PaGZY-0001EI-BD@smtp.tuxdriver.com>
2011-01-04 23:54 ` Frederic Weisbecker [this message]
2011-01-05 0:40 ` [RFC patch 2/5] trace event skb fix unassigned field Mathieu Desnoyers
2011-01-05 0:49 ` Frederic Weisbecker
2011-01-05 1:21 ` Mathieu Desnoyers
2011-01-05 11:59 ` Neil Horman
2011-01-05 13:26 ` Mathieu Desnoyers
2011-01-06 0:01 ` Steven Rostedt
2011-01-04 23:16 [RFC patch 0/5] Trace event fixes and cleanups Mathieu Desnoyers
2011-01-04 23:16 ` [RFC patch 2/5] trace event skb fix unassigned field Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104235418.GD2911@nowhere \
--to=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=nhorman@tuxdriver.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox