public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Jamie Lokier <jamie@shareable.org>, Thomas Weber <swirl@gmx.li>,
	gleb@redhat.com, virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] virtio-pci: add softlinks between virtio and pci
Date: Wed, 5 Jan 2011 21:17:11 +0200	[thread overview]
Message-ID: <20110105191711.GA27489@redhat.com> (raw)

We sometimes need to map between the virtio device and
the given pci device. One such use is OS installer that
gets the boot pci device from BIOS and needs to
find the relevant block device. Since it can't,
installation fails.

Supply softlinks between these to make it possible.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

Gleb, could you please ack that this patch below
will be enough to fix the installer issue that
you see?

 drivers/virtio/virtio_pci.c |   18 +++++++++++++++++-
 1 files changed, 17 insertions(+), 1 deletions(-)

diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
index ef8d9d5..06eb2f8 100644
--- a/drivers/virtio/virtio_pci.c
+++ b/drivers/virtio/virtio_pci.c
@@ -25,6 +25,7 @@
 #include <linux/virtio_pci.h>
 #include <linux/highmem.h>
 #include <linux/spinlock.h>
+#include <linux/sysfs.h>
 
 MODULE_AUTHOR("Anthony Liguori <aliguori@us.ibm.com>");
 MODULE_DESCRIPTION("virtio-pci");
@@ -667,8 +668,21 @@ static int __devinit virtio_pci_probe(struct pci_dev *pci_dev,
 	if (err)
 		goto out_set_drvdata;
 
-	return 0;
+	err = sysfs_create_link(&pci_dev->dev.kobj, &vp_dev->vdev.dev.kobj,
+				"virtio_device");
+	if (err)
+		goto out_register_device;
+
+	err = sysfs_create_link(&vp_dev->vdev.dev.kobj, &pci_dev->dev.kobj,
+				"bus_device");
+	if (err)
+		goto out_create_link;
 
+	return 0;
+out_create_link:
+	sysfs_remove_link(&pci_dev->dev.kobj, "virtio_device");
+out_register_device:
+	unregister_virtio_device(&vp_dev->vdev);
 out_set_drvdata:
 	pci_set_drvdata(pci_dev, NULL);
 	pci_iounmap(pci_dev, vp_dev->ioaddr);
@@ -685,6 +699,8 @@ static void __devexit virtio_pci_remove(struct pci_dev *pci_dev)
 {
 	struct virtio_pci_device *vp_dev = pci_get_drvdata(pci_dev);
 
+	sysfs_remove_link(&vp_dev->vdev.dev.kobj, "bus_device");
+	sysfs_remove_link(&pci_dev->dev.kobj, "virtio_device");
 	unregister_virtio_device(&vp_dev->vdev);
 }
 
-- 
1.7.3.2.91.g446ac

             reply	other threads:[~2011-01-05 19:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05 19:17 Michael S. Tsirkin [this message]
2011-01-05 19:28 ` [PATCH] virtio-pci: add softlinks between virtio and pci Anthony Liguori
2011-01-05 19:38   ` Michael S. Tsirkin
2011-01-05 20:06     ` Anthony Liguori
2011-01-05 20:05   ` Michael S. Tsirkin
2011-01-05 20:08     ` Anthony Liguori
2011-01-05 21:15       ` Michael S. Tsirkin
2011-01-06  8:51 ` Gleb Natapov
2011-01-07  8:54 ` Milton Miller
2011-01-07  8:55   ` [PATCH] virtio: remove virtio-pci root device Milton Miller
2011-01-07 10:24     ` Michael S. Tsirkin
2011-01-09 15:18     ` Michael S. Tsirkin
2011-01-10 11:18       ` Gleb Natapov
2011-01-10 11:22         ` Michael S. Tsirkin
2011-01-10 11:27           ` Gleb Natapov
2011-01-10 11:42             ` Gleb Natapov
2011-01-10 12:08               ` Michael S. Tsirkin
2011-01-10 12:50                 ` Gleb Natapov
2011-01-10 13:31                   ` Michael S. Tsirkin
2011-01-10 13:40                     ` Gleb Natapov
2011-01-10 14:19                       ` Michael S. Tsirkin
2011-01-10 17:10     ` Gleb Natapov
2011-01-10 17:19       ` Michael S. Tsirkin
2011-01-17  0:33         ` Rusty Russell
2011-01-10 17:44     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105191711.GA27489@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=gleb@redhat.com \
    --cc=jamie@shareable.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=swirl@gmx.li \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox