From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753967Ab1AFVRm (ORCPT ); Thu, 6 Jan 2011 16:17:42 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44136 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753546Ab1AFVRk (ORCPT ); Thu, 6 Jan 2011 16:17:40 -0500 Date: Thu, 6 Jan 2011 13:16:59 -0800 From: Andrew Morton To: Randy Dunlap Cc: Janusz Krzysztofik , Richard Purdie , "linux-fbdev@vger.kernel.org" , linux-kernel@vger.kernel.org, "linux-omap@vger.kernel.org" , Paul Mundt Subject: Re: [RESEND #2] [PATCH v2] LEDS: Add output invertion option to backlight trigger Message-Id: <20110106131659.cedf8500.akpm@linux-foundation.org> In-Reply-To: <20110106130856.22b92a8b.randy.dunlap@oracle.com> References: <201012091441.51846.jkrzyszt@tis.icnet.pl> <20110106130440.cfd77c8e.akpm@linux-foundation.org> <20110106130856.22b92a8b.randy.dunlap@oracle.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jan 2011 13:08:56 -0800 Randy Dunlap wrote: > On Thu, 6 Jan 2011 13:04:40 -0800 Andrew Morton wrote: > > > On Thu, 9 Dec 2010 14:41:50 +0100 > > Janusz Krzysztofik wrote: > > > > > +static DEVICE_ATTR(invert, 0644, bl_trig_invert_show, bl_trig_invert_store); > > > > This new sysfs file should be documented. Where would be an > > appropriate place for that? Documentation/leds-class.txt doesn't > > mention a sysfs API at all. > > -- > > in Documentation/ABI/, where all sysfs interface info lives. > Spose so. Documentation/ABI/stable/sysfs-class-backlight does have some stuff in it. Personally I tend to regard Documentation/ABI/ as fairly useless incomprehensible stuff, maintained to keep Greg happy ;) It'd be better to have a nice little well-maintained document for a subsystem such as this which actually explains its operation in a useful-to-humans way. Rather than just mechanically filling out forms. But a Documentation/ABI update is a heck of a lot better than nothing.