From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Urs Fleisch <urs.fleisch@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
LM Sensors <lm-sensors@lm-sensors.org>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH V4] hwmon: driver for Sensirion SHT21 humidity and temperature sensor
Date: Thu, 6 Jan 2011 07:21:52 -0800 [thread overview]
Message-ID: <20110106152152.GB9053@ericsson.com> (raw)
In-Reply-To: <4D25A04F.7070304@cam.ac.uk>
On Thu, Jan 06, 2011 at 05:58:23AM -0500, Jonathan Cameron wrote:
> On 01/06/11 07:43, Urs Fleisch wrote:
> > Thanks for the review, Jonathan and Guenter.
> >
> > Changes:
> > - removed user register related sysfs attributes, keeping only temp1_input and
> > humidity1_input
> > - cleaned up code flow when returning errors for better readability
> Short and clean. I do wonder if you want some of those users register
> bits available via platform data though. Perhaps that can be added in
> a later patch as and when someone needs them.
Only thing missing is Documentation/hwmon/sht21.
Urs, can you add that ?
Thanks,
Guenter
next prev parent reply other threads:[~2011-01-06 15:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 12:45 [PATCH] hwmon: driver for Sensirion SHT21 humidity and temperature sensor Urs Fleisch
2010-12-31 15:02 ` Jonathan Cameron
2011-01-03 7:14 ` Urs Fleisch
2011-01-03 11:06 ` Jonathan Cameron
2011-01-03 14:01 ` [PATCH V3] " Urs Fleisch
2011-01-03 15:12 ` Guenter Roeck
2011-01-03 14:53 ` [PATCH] " Guenter Roeck
2011-01-03 18:09 ` Guenter Roeck
2011-01-04 12:13 ` Jonathan Cameron
2011-01-04 15:28 ` Guenter Roeck
2011-01-04 19:00 ` Urs Fleisch
2011-01-04 19:42 ` Guenter Roeck
2011-01-06 7:43 ` [PATCH V4] " Urs Fleisch
2011-01-06 10:58 ` Jonathan Cameron
2011-01-06 15:21 ` Guenter Roeck [this message]
2011-01-06 15:56 ` Guenter Roeck
2011-01-07 7:15 ` [PATCH V5] " Urs Fleisch
2011-01-07 11:55 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106152152.GB9053@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=urs.fleisch@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox