From: Greg KH <gregkh@suse.de>
To: Ferenc Wagner <wferi@niif.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Replace the dangerous to_root_device macro with an inline function
Date: Thu, 6 Jan 2011 08:20:32 -0800 [thread overview]
Message-ID: <20110106162032.GA10189@suse.de> (raw)
In-Reply-To: <44482f820e5700f952825c9b5ec6a9f080975d79.1294326889.git.wferi@niif.hu>
On Thu, Jan 06, 2011 at 04:24:24PM +0100, Ferenc Wagner wrote:
> The original macro worked only when applied to variables named 'dev'.
> While this could have been fixed by simply renaming the macro argument,
> a more type-safe replacement is preferred.
Preferred for what? This is a local macro, not exported to anything
else, is it causing problems today within this single file?
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-06 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 15:24 [PATCH 2/2] Replace the dangerous to_root_device macro with an inline function Ferenc Wagner
2011-01-06 15:28 ` Ferenc Wagner
2011-01-06 16:20 ` Greg KH [this message]
2011-01-06 20:47 ` Ferenc Wagner
2011-01-06 20:52 ` Greg KH
2011-01-07 14:17 ` [PATCH] " Ferenc Wagner
2011-01-07 14:21 ` [PATCH 2/2] " Ferenc Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106162032.GA10189@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox