public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Jeff Moyer <jmoyer@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Alan.Brunelle@hp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trace event block fix unassigned field
Date: Thu, 6 Jan 2011 14:54:28 -0500	[thread overview]
Message-ID: <20110106195428.GA3114@Krystal> (raw)
In-Reply-To: <4D261B23.5040100@kernel.dk>

* Jens Axboe (axboe@kernel.dk) wrote:
> On 2011-01-06 19:43, Mathieu Desnoyers wrote:
> > The "error" field in block_bio_complete is not assigned, leaving the
> > memory area uninitialized (keeping garbage data). Pass an additional
> > tracepoint argument to this event to initialize this field.
> 
> Thanks guys, applied.

Thanks Jens. A side-note for Frederic and Steven: for this patch specifically,
going through the block layer tree seems like the right approach, because we
also modify the tracepoint caller code.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com

      reply	other threads:[~2011-01-06 19:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 18:43 [PATCH] trace event block fix unassigned field Mathieu Desnoyers
2011-01-06 19:42 ` Jens Axboe
2011-01-06 19:54   ` Mathieu Desnoyers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106195428.GA3114@Krystal \
    --to=mathieu.desnoyers@efficios.com \
    --cc=Alan.Brunelle@hp.com \
    --cc=axboe@kernel.dk \
    --cc=fweisbec@gmail.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox