From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf tools: Pass whole attr to event selectors
Date: Fri, 7 Jan 2011 01:42:34 -0200 [thread overview]
Message-ID: <20110107034234.GA7931@ghostprotocols.net> (raw)
In-Reply-To: <1294369869.20563.19.camel@minggr.sh.intel.com>
Em Fri, Jan 07, 2011 at 11:11:09AM +0800, Lin Ming escreveu:
> Since commit 69aad6f1(perf tools: Introduce event selectors), only
> perf_event_attr::type and ::config are passed to event selector, which
> makes perf tool not work correctly.
>
> For example, PEBS does not work because perf_event_attr::precise_ip is
> not passed to the syscall.
Right, thanks for the fix, Ingo, I'm adding this to my perf/core tree.
- Arnaldo
next prev parent reply other threads:[~2011-01-07 3:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 3:11 [PATCH] perf tools: Pass whole attr to event selectors Lin Ming
2011-01-07 3:42 ` Arnaldo Carvalho de Melo [this message]
2011-01-07 15:31 ` [tip:perf/core] " tip-bot for Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107034234.GA7931@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox