From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: [PATCH 1/7] tracing: Include module.h in define_trace.h
Date: Sat, 08 Jan 2011 15:16:00 -0500 [thread overview]
Message-ID: <20110108201644.606765771@goodmis.org> (raw)
In-Reply-To: 20110108201559.130182944@goodmis.org
[-- Attachment #1: 0001-tracing-Include-module.h-in-define_trace.h.patch --]
[-- Type: text/plain, Size: 1263 bytes --]
From: Steven Rostedt <srostedt@redhat.com>
While doing some developing, Peter Zijlstra and I have found
that if a CREATE_TRACE_POINTS include is done before module.h
is included, it can break the build.
We have been lucky so far that this has not broke the build
since module.h is included in almost everything.
Reported-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
include/trace/define_trace.h | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h
index b0b4eb2..da39b22 100644
--- a/include/trace/define_trace.h
+++ b/include/trace/define_trace.h
@@ -21,6 +21,16 @@
#undef CREATE_TRACE_POINTS
#include <linux/stringify.h>
+/*
+ * module.h includes tracepoints, and because ftrace.h
+ * pulls in module.h:
+ * trace/ftrace.h -> linux/ftrace_event.h -> linux/perf_event.h ->
+ * linux/ftrace.h -> linux/module.h
+ * we must include module.h here before we play with any of
+ * the TRACE_EVENT() macros, otherwise the tracepoints included
+ * by module.h may break the build.
+ */
+#include <linux/module.h>
#undef TRACE_EVENT
#define TRACE_EVENT(name, proto, args, tstruct, assign, print) \
--
1.7.2.3
next prev parent reply other threads:[~2011-01-08 20:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-08 20:15 [PATCH 0/7] [GIT PULL][2.6.38] tracing: updates and fixes Steven Rostedt
2011-01-08 20:16 ` Steven Rostedt [this message]
2011-01-08 20:16 ` [PATCH 2/7] tracing/trivial: Add missing comma in TRACE_EVENT comment Steven Rostedt
2011-01-08 20:16 ` [PATCH 3/7] tracing: remove duplicate null-pointer check in skb tracepoint Steven Rostedt
2011-01-08 20:16 ` [PATCH 4/7] tracepoint: Add __rcu annotation Steven Rostedt
2011-01-08 20:16 ` [PATCH 5/7] tracing: Fix preempt count leak Steven Rostedt
2011-01-08 20:16 ` [PATCH 6/7] tracing: Fix TRACE_EVENT power tracepoint creation Steven Rostedt
2011-01-08 20:16 ` [PATCH 7/7] dynamic debug: Fix build issue with older gcc Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110108201644.606765771@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox