From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: [RFC patch 02/28] trace event sample remove semicolons, specify need for ifdef around declarations
Date: Sun, 09 Jan 2011 16:59:29 -0500 [thread overview]
Message-ID: <20110109220508.364614441@efficios.com> (raw)
In-Reply-To: 20110109215927.633266833@efficios.com
[-- Attachment #1: trace-event-sample-remove-semicolons.patch --]
[-- Type: text/plain, Size: 1704 bytes --]
Part of the gradual TRACE_EVENT() semicolon removal. Enables creation of array
of events, thus saving space for trace event probes.
Protecting declarations with ifndef _TRACE_SAMPLE_DEF_ is required if we want to
ensure that, e.g., structure forward declarations do not generate extra
semicolons. It's already needed for enumerations and static inline functions
declarations, but not documented, so document it here.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Li Zefan <lizf@cn.fujitsu.com>
---
samples/trace_events/trace-events-sample.h | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
Index: linux-2.6-lttng/samples/trace_events/trace-events-sample.h
===================================================================
--- linux-2.6-lttng.orig/samples/trace_events/trace-events-sample.h
+++ linux-2.6-lttng/samples/trace_events/trace-events-sample.h
@@ -41,6 +41,18 @@
*/
#include <linux/tracepoint.h>
+#ifndef _TRACE_SAMPLE_DEF_
+#define _TRACE_SAMPLE_DEF_
+
+/*
+ * All static inline functions, enumerations, types and structures declarations,
+ * as well as structure forward declarations, should be surrounded by
+ * _TRACE_SAMPLE_DEF_ preprocessor idefs (where SAMPLE is the name of the trace
+ * system).
+ */
+
+#endif /* _TRACE_SAMPLE_DEF_ */
+
/*
* The TRACE_EVENT macro is broken up into 5 parts.
*
@@ -91,7 +103,7 @@ TRACE_EVENT(foo_bar,
),
TP_printk("foo %s %d", __entry->foo, __entry->bar)
-);
+)
#endif
/***** NOTICE! The #if protection ends here. *****/
next prev parent reply other threads:[~2011-01-09 22:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 21:59 [RFC patch 00/28] Removal of trace event semicolons Mathieu Desnoyers
2011-01-09 21:59 ` Mathieu Desnoyers [this message]
2011-01-09 21:59 ` [RFC patch 03/28] trace event bkl remove semicolons Mathieu Desnoyers
2011-01-15 23:40 ` Frederic Weisbecker
2011-01-09 21:59 ` [RFC patch 04/28] trace event block remove semicolumns Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 05/28] trace event ext4 remove semicolons Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 06/28] trace event irq " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 07/28] trace event jbd2 " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 08/28] trace event kmem " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 09/28] trace event kvm " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 10/28] trace event lock " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 11/28] trace event mce " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 12/28] trace event module " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 13/28] trace event napi " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 14/28] trace event net " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 15/28] trace event power " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 16/28] trace event sched remove trailing semicolon Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 17/28] trace event scsi remove semicolons Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 18/28] trace event signal " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 19/28] trace event skb " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 20/28] trace event syscalls " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 21/28] trace event timer " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 22/28] trace event vmscan " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 23/28] trace event workqueue " Mathieu Desnoyers
2011-01-09 22:10 ` Tejun Heo
2011-01-09 21:59 ` [RFC patch 24/28] trace event writeback " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 25/28] trace event wireless " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 26/28] trace event video gpu " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 27/28] trace event fs " Mathieu Desnoyers
2011-01-09 23:30 ` Dave Chinner
2011-01-09 23:43 ` Mathieu Desnoyers
2011-01-09 23:45 ` Mathieu Desnoyers
2011-01-09 23:44 ` Mathieu Desnoyers
2011-01-10 9:09 ` Steven Whitehouse
2011-01-09 21:59 ` [RFC patch 28/28] trace event powerpc " Mathieu Desnoyers
2011-01-15 23:44 ` [RFC patch 00/28] Removal of trace event semicolons Frederic Weisbecker
2011-01-17 1:19 ` Mathieu Desnoyers
2011-01-17 16:41 ` Frederic Weisbecker
2011-01-17 17:36 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110109220508.364614441@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox