Re: [RFC patch 00/28] Removal of trace event semicolons

Frederic Weisbecker
2011-01-17T16:41:34Z

On Sun, Jan 16, 2011 at 08:19:16PM -0500, Mathieu Desnoyers wrote:
> * Frederic Weisbecker (fweisbec@gmail.com) wrote:
> > On Sun, Jan 09, 2011 at 04:59:27PM -0500, Mathieu Desnoyers wrote:
> > > Hi,
> > >
> > > I am hereby proposing the removal of trailing semicolons within the trace event
> > > headers.
> > >
> > > Please refer to "patch 01: TRACE_EVENT: gradual semicolon removal" for
> > > explanation of this change. This patchset is based on the 2.6.37 kernel.
> > >
> > > Feedback is welcome,
> > >
> > > Thanks,
> > >
> > > Mathieu
> >
> >
> > So, it seems there is no issue in spreading the whole into
> > each relevant trees?
>
> Because there is a dependency on patch 01, I think it would be much less painful
> to bring in the whole patchset through the tracing tree rather than each
> targeted tree. Otherwise, we have to ensure that each tree has pulled the commit
> from the tracing tree before pulling the patches that depend on it.

Ok.

> And it only really touches the include/trace/ header files, so it's not as if it
> touched any specific subsystem code.

Beware, there are many trace events all over the kernel, not only in include/trace