public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Thomas Gleixner <tglx@linutronix.de>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>,
	Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>,
	Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>,
	James Bottomley <James.Bottomley@suse.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [RFC patch 17/28] trace event scsi remove semicolons
Date: Sun, 09 Jan 2011 16:59:44 -0500	[thread overview]
Message-ID: <20110109220510.887593848@efficios.com> (raw)
In-Reply-To: 20110109215927.633266833@efficios.com

[-- Attachment #1: trace-event-scsi-remove-semicolons.patch --]
[-- Type: text/plain, Size: 2723 bytes --]

Part of the gradual TRACE_EVENT() semicolon removal. Enables creation of array
of events, thus saving space for trace event probes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Steven Rostedt <rostedt@goodmis.org>
CC: Frederic Weisbecker <fweisbec@gmail.com>
CC: Ingo Molnar <mingo@elte.hu>
CC: Thomas Gleixner <tglx@linutronix.de>
CC: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
CC: Tomohiro Kusumi <kusumi.tomohiro@jp.fujitsu.com>
CC: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
CC: James Bottomley <James.Bottomley@suse.de>
CC: Martin K. Petersen <martin.petersen@oracle.com>
---
 include/trace/events/scsi.h |   17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

Index: linux-2.6-lttng/include/trace/events/scsi.h
===================================================================
--- linux-2.6-lttng.orig/include/trace/events/scsi.h
+++ linux-2.6-lttng/include/trace/events/scsi.h
@@ -9,6 +9,9 @@
 #include <linux/tracepoint.h>
 #include <linux/trace_seq.h>
 
+#ifndef _TRACE_SCSI_DEF_
+#define _TRACE_SCSI_DEF_
+
 #define scsi_opcode_name(opcode)	{ opcode, #opcode }
 #define show_opcode_name(val)					\
 	__print_symbolic(val,					\
@@ -187,6 +190,8 @@
 const char *scsi_trace_parse_cdb(struct trace_seq*, unsigned char*, int);
 #define __parse_cdb(cdb, len) scsi_trace_parse_cdb(p, cdb, len)
 
+#endif /* _TRACE_SCSI_DEF_ */
+
 TRACE_EVENT(scsi_dispatch_cmd_start,
 
 	TP_PROTO(struct scsi_cmnd *cmd),
@@ -224,7 +229,7 @@ TRACE_EVENT(scsi_dispatch_cmd_start,
 		  show_opcode_name(__entry->opcode),
 		  __parse_cdb(__get_dynamic_array(cmnd), __entry->cmd_len),
 		  __print_hex(__get_dynamic_array(cmnd), __entry->cmd_len))
-);
+)
 
 TRACE_EVENT(scsi_dispatch_cmd_error,
 
@@ -266,7 +271,7 @@ TRACE_EVENT(scsi_dispatch_cmd_error,
 		  __parse_cdb(__get_dynamic_array(cmnd), __entry->cmd_len),
 		  __print_hex(__get_dynamic_array(cmnd), __entry->cmd_len),
 		  __entry->rtn)
-);
+)
 
 DECLARE_EVENT_CLASS(scsi_cmd_done_timeout_template,
 
@@ -312,15 +317,15 @@ DECLARE_EVENT_CLASS(scsi_cmd_done_timeou
 		  show_hostbyte_name(((__entry->result) >> 16) & 0xff),
 		  show_msgbyte_name(((__entry->result) >> 8) & 0xff),
 		  show_statusbyte_name(__entry->result & 0xff))
-);
+)
 
 DEFINE_EVENT(scsi_cmd_done_timeout_template, scsi_dispatch_cmd_done,
 	     TP_PROTO(struct scsi_cmnd *cmd),
-	     TP_ARGS(cmd));
+	     TP_ARGS(cmd))
 
 DEFINE_EVENT(scsi_cmd_done_timeout_template, scsi_dispatch_cmd_timeout,
 	     TP_PROTO(struct scsi_cmnd *cmd),
-	     TP_ARGS(cmd));
+	     TP_ARGS(cmd))
 
 TRACE_EVENT(scsi_eh_wakeup,
 
@@ -337,7 +342,7 @@ TRACE_EVENT(scsi_eh_wakeup,
 	),
 
 	TP_printk("host_no=%u", __entry->host_no)
-);
+)
 
 #endif /*  _TRACE_SCSI_H */
 


  parent reply	other threads:[~2011-01-09 22:05 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-09 21:59 [RFC patch 00/28] Removal of trace event semicolons Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 02/28] trace event sample remove semicolons, specify need for ifdef around declarations Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 03/28] trace event bkl remove semicolons Mathieu Desnoyers
2011-01-15 23:40   ` Frederic Weisbecker
2011-01-09 21:59 ` [RFC patch 04/28] trace event block remove semicolumns Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 05/28] trace event ext4 remove semicolons Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 06/28] trace event irq " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 07/28] trace event jbd2 " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 08/28] trace event kmem " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 09/28] trace event kvm " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 10/28] trace event lock " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 11/28] trace event mce " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 12/28] trace event module " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 13/28] trace event napi " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 14/28] trace event net " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 15/28] trace event power " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 16/28] trace event sched remove trailing semicolon Mathieu Desnoyers
2011-01-09 21:59 ` Mathieu Desnoyers [this message]
2011-01-09 21:59 ` [RFC patch 18/28] trace event signal remove semicolons Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 19/28] trace event skb " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 20/28] trace event syscalls " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 21/28] trace event timer " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 22/28] trace event vmscan " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 23/28] trace event workqueue " Mathieu Desnoyers
2011-01-09 22:10   ` Tejun Heo
2011-01-09 21:59 ` [RFC patch 24/28] trace event writeback " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 25/28] trace event wireless " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 26/28] trace event video gpu " Mathieu Desnoyers
2011-01-09 21:59 ` [RFC patch 27/28] trace event fs " Mathieu Desnoyers
2011-01-09 23:30   ` Dave Chinner
2011-01-09 23:43     ` Mathieu Desnoyers
2011-01-09 23:45       ` Mathieu Desnoyers
2011-01-09 23:44     ` Mathieu Desnoyers
2011-01-10  9:09       ` Steven Whitehouse
2011-01-09 21:59 ` [RFC patch 28/28] trace event powerpc " Mathieu Desnoyers
2011-01-15 23:44 ` [RFC patch 00/28] Removal of trace event semicolons Frederic Weisbecker
2011-01-17  1:19   ` Mathieu Desnoyers
2011-01-17 16:41     ` Frederic Weisbecker
2011-01-17 17:36       ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110109220510.887593848@efficios.com \
    --to=mathieu.desnoyers@efficios.com \
    --cc=James.Bottomley@suse.de \
    --cc=fweisbec@gmail.com \
    --cc=kusumi.tomohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tokunaga.keiich@jp.fujitsu.com \
    --cc=xiaoguangrong@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox