From: Greg KH <gregkh@suse.de>
To: ahern.michael.t@gmail.com
Cc: u.kleine-koenig@pengutronix.de, julia@diku.dk, nikai@nikai.net,
morgan.gatti@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Staging: comedi: fix line-length coding style issue in usbduxfast.c
Date: Sun, 9 Jan 2011 22:36:16 -0800 [thread overview]
Message-ID: <20110110063616.GB3016@suse.de> (raw)
In-Reply-To: <1294614196-6665-1-git-send-email-ahern.michael.t@gmail.com>
On Mon, Jan 10, 2011 at 10:03:12AM +1100, ahern.michael.t@gmail.com wrote:
> From: mah <ahern.michael.t@gmail.com>
Please put your "real" name here, the same one you put down below in the
Signed-off-by: line.
> This patch to usbduxfast.c file that fixes warnings found by checkpatch.pl tool
Which warnings?
> -static void usbduxfast_firmware_request_complete_handler(const struct firmware
> +static void usbduxfast_firmware_req_complete_handler(const struct firmware
> *fw, void *context)
> {
> struct usbduxfastsub_s *usbduxfastsub_tmp = context;
> @@ -1577,7 +1585,7 @@ static int usbduxfastsub_probe(struct usb_interface *uinterf,
> &udev->dev,
> GFP_KERNEL,
> usbduxfastsub + index,
> - usbduxfast_firmware_request_complete_handler);
> + usbduxfast_firmware_req_complete_handler);
Renaming the function name just to make the line-length work isn't ok.
Just don't make this change.
thanks,
greg k-h
prev parent reply other threads:[~2011-01-10 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-09 23:03 [PATCH 1/5] Staging: comedi: fix line-length coding style issue in usbduxfast.c ahern.michael.t
2011-01-09 23:03 ` [PATCH 2/5] Staging: comedi: whitespace ahern.michael.t
2011-01-09 23:03 ` [PATCH 3/5] Coding style in unioxx5.c KERN_ facility level and coding style warnings as reported by checkpatch.pl Signed-off-by: Michael Ahern <ahern.michael.t@gmail.com> ahern.michael.t
2011-01-10 6:39 ` Greg KH
2011-01-09 23:03 ` [PATCH 4/5] Coding style in serial2002 Patch that resolves braces and KERN_ warnings by checkpatch.pl Signed-off-by: Michael Ahern ahern.michael.t
2011-01-09 23:56 ` Joe Perches
2011-01-09 23:03 ` [PATCH 5/5] Coding style in s626 Patch that resolves line length warnings by checkpatch.pl Signed-off-by: Michael Ahern <ahern.michael.t@gmail.com> ahern.michael.t
2011-01-10 6:39 ` Greg KH
2011-01-10 6:36 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110063616.GB3016@suse.de \
--to=gregkh@suse.de \
--cc=ahern.michael.t@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=morgan.gatti@gmail.com \
--cc=nikai@nikai.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox