From: Alan Cox <alan@linux.intel.com>
To: "Gorby, Russ" <russ.gorby@intel.com>
Cc: "gregkh@suse.de" <gregkh@suse.de>,
"segoon@openwall.com" <segoon@openwall.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Ahmed, Suhail" <suhail.ahmed@intel.com>
Subject: Re: [PATCH 4/7] serial: ifx6x60: set SPI max_speed_hz based on platform type
Date: Mon, 10 Jan 2011 14:05:38 +0000 [thread overview]
Message-ID: <20110110140538.2d584937@bob.linux.org.uk> (raw)
In-Reply-To: <4C5E6457CD7911469A07260381288C28CB7E0263@orsmsx502.amr.corp.intel.com>
> Use_dma is used so the protocol driver matches the expectations
> (capabilities) of the controller driver it attaches to. In the
> general case I would think it could support several different
> controller drivers that might have differing capabilities. Currently
> the driver does assume the value of use_dma is constant for a
> platform so putting this indication in the platform data would
> suffice (for now) but to me, this is not really a platform attribute.
> Is there a better way to handle this is?
The driver should know nothing about the plumbing itself. So the
platform data should deal with this and pass it in generic terms.
In the Intel MID case arch/x86/platform/mrst/ should know about whether
DMA can be used and what mode the SFI controller should be in. The bits
that are in ifx6x60.c should be as architecture neutral as possible.
Alan
next prev parent reply other threads:[~2011-01-10 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/7] IFX6X60 patchset: 01/05/2011>
2011-01-06 0:05 ` [PATCH 0/7] IFX6X60 patchset: 01/05/2011 Russ Gorby
2011-01-06 0:14 ` Greg KH
2011-01-06 0:33 ` Gorby, Russ
2011-01-06 3:19 ` Greg KH
2011-01-06 0:05 ` [PATCH 1/7] serial: ifx6x60: fixed call to tty_port_init Russ Gorby
2011-01-06 0:24 ` Alan Cox
2011-01-06 0:05 ` [PATCH 2/7] serial: ifx6x60: dma_alloc_coherent must use parent dev Russ Gorby
2011-01-06 0:05 ` [PATCH 3/7] serial: ifx6x60: changed internal bpw from boolean to int Russ Gorby
2011-01-06 0:25 ` Alan Cox
2011-01-06 0:05 ` [PATCH 4/7] serial: ifx6x60: set SPI max_speed_hz based on platform type Russ Gorby
2011-01-06 0:27 ` Alan Cox
2011-01-06 21:30 ` Gorby, Russ
2011-01-10 14:05 ` Alan Cox [this message]
2011-01-06 0:05 ` [PATCH 5/7] serial: ifx6x60: probe routine needs to call spi_setup Russ Gorby
2011-01-06 0:05 ` [PATCH 6/7] serial: ifx6x60: fix modem names to ones recognized by firmware Russ Gorby
2011-01-06 0:29 ` Alan Cox
2011-01-06 0:05 ` [PATCH 7/7] serial: ifx6x60: minor cleanup Russ Gorby
2011-01-06 0:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110140538.2d584937@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=russ.gorby@intel.com \
--cc=segoon@openwall.com \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox