From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754038Ab1AJOPr (ORCPT ); Mon, 10 Jan 2011 09:15:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31351 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756Ab1AJOPq (ORCPT ); Mon, 10 Jan 2011 09:15:46 -0500 Date: Mon, 10 Jan 2011 15:08:17 +0100 From: Oleg Nesterov To: Stefan Priebe - Profihost AG Cc: Kay Sievers , Dhaval Giani , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [BUG stable, 2.6.32.27] sched: delayed cleanup of user_struct Message-ID: <20110110140817.GA31708@redhat.com> References: <4D2AB8F7.7030506@profihost.ag> <20110110114913.GA22298@redhat.com> <20110110123630.GA27057@redhat.com> <4D2AFFB5.5000807@profihost.ag> <20110110133545.GA30163@redhat.com> <4D2B113A.2060303@profihost.ag> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D2B113A.2060303@profihost.ag> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10, Stefan Priebe - Profihost AG wrote: > > Main problem - right i can't reproduce it. But the system was crashing > two times more in the past. > > You can find the logs here: > http://pastebin.com/hNd15E8K Good. Sadly, I didn't see this trace before... kernel BUG at kernel/workqueue.c:287! this matches "INIT_DELAYED_WORK() can corrupt the pending work" I mentioned. >> Or. You can revert >> b00bc0b237055b4c45816325ee14f0bd83e6f590 >> uids: Prevent tear down race >> >> 3959214f971417f4162926ac52ad4cd042958caa >> sched: delayed cleanup of user_struct > Not sure if it is a good idea to introduce another race again. Which race? b00bc0b237055b4c45816325ee14f0bd83e6f590 fixes the race, yes. But this race was introduced by 3959214f971417f4162926ac52ad4cd042958caa. And afaics the latter commit is optimization... Anyway, this is up to you, of course. Oleg.