From: Greg KH <greg@kroah.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Borislav Petkov <borislav.petkov@amd.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH 3/3] x86: usb handoff in early_quirk
Date: Mon, 10 Jan 2011 08:00:01 -0800 [thread overview]
Message-ID: <20110110160001.GC5275@kroah.com> (raw)
In-Reply-To: <4D2A13BC.3000003@kernel.org>
On Sun, Jan 09, 2011 at 11:59:56AM -0800, Yinghai Lu wrote:
>
> some systems keep getting
> APIC calibration not consistent with PM-Timer: 139ms instead of 100ms
> APIC delta adjusted to PM-Timer: 831249 (1163736)
>
> USB legacy SMI handler is not disabled at that time.
>
> Try to disable USB legacy support early with this patch.
> So later APIC Timer calibration don't get messed up by USB legacy support SMI handler.
> After this patch, that warning never show up for 100 reboot tests.
But is that warning a real issue? Does it cause problems for the user
(becides annoying them of course)?
> reuse code from drivers/usb/host/pci-quirks.c
> with changes
> 1. delay and sleep ===> io_delay
> 2. dev_warn etc to pr_warn(num, slot, func...)
Why change this function? What's wrong with dev_warn()? It's much more
descriptive of the device that is being referred to.
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-10 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D2A1152.1040903@kernel.org>
2011-01-09 19:59 ` [PATCH 1/3] pci, usb: Seperate usb handoff func to another file Yinghai Lu
2011-01-09 21:09 ` Benjamin Herrenschmidt
2011-01-10 7:01 ` Yinghai Lu
2011-01-10 9:38 ` Benjamin Herrenschmidt
2011-01-10 15:57 ` Greg KH
2011-01-09 19:59 ` [PATCH 2/3] x86: early_quirk check all dev/func in domain 0 Yinghai Lu
2011-01-10 16:01 ` Greg KH
2011-01-10 19:53 ` Yinghai Lu
2011-01-09 19:59 ` [PATCH 3/3] x86: usb handoff in early_quirk Yinghai Lu
2011-01-10 16:00 ` Greg KH [this message]
2011-01-09 22:07 Sander Eikelenboom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110160001.GC5275@kroah.com \
--to=greg@kroah.com \
--cc=borislav.petkov@amd.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sarah.a.sharp@linux.intel.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox