From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755328Ab1AKDj6 (ORCPT ); Mon, 10 Jan 2011 22:39:58 -0500 Received: from kroah.org ([198.145.64.141]:41658 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580Ab1AKDjw (ORCPT ); Mon, 10 Jan 2011 22:39:52 -0500 Date: Mon, 10 Jan 2011 19:35:56 -0800 From: Greg KH To: Yinghai Lu Cc: Jesse Barnes , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Benjamin Herrenschmidt , "linux-pci@vger.kernel.org" , linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH -v3 0/4] x86, usb, pci: Disable usb legacy support early Message-ID: <20110111033556.GC9709@kroah.com> References: <4D2A1382.7010407@kernel.org> <4D2AC6BF.3010907@kernel.org> <4D2BA8FE.9090204@kernel.org> <20110111010739.GC32585@kroah.com> <4D2BB1A4.5090404@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D2BB1A4.5090404@kernel.org> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 10, 2011 at 05:25:56PM -0800, Yinghai Lu wrote: > On 01/10/2011 05:07 PM, Greg KH wrote: > > On Mon, Jan 10, 2011 at 04:49:02PM -0800, Yinghai Lu wrote: > >> > >> Move quirks for usb handoff early for x86. > >> > >> So we can get stable result when trying to calibrate apic timer with pm-timer. > > > > I still fail to understand _why_ you are making these changes. > > > > Exactly what problem do you currently have, on what hardware, that this > > patch set solves? > 1. remove the warning What warning? > 2. apic timer clockevent will be more accurate instead of use PM to calibrate it. > on Intel newer system with 128 logical cpus or more. Is that a problem? > guess SMI handler for USB legacy support may need more time coordinate between those cpus. Are you sure? And again, please post this in your messages, otherwise we are just guessing, and if we have to guess, we will error on the "ignore the patch" side. You need to sell us on why we should accept these patches, so far, I see no real reason at all for them. good luck, greg k-h