From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Jeremy Kerr <jeremy.kerr@canonical.com>,
Nicolas Pitre <nicolas.pitre@canonical.com>
Subject: Re: [RFC] arm: Defer lookup of machine_type and vet of atags to setup.c
Date: Tue, 11 Jan 2011 15:48:33 +0000 [thread overview]
Message-ID: <20110111154833.GF11039@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110111153630.GB2707@angua.secretlab.ca>
On Tue, Jan 11, 2011 at 08:36:30AM -0700, Grant Likely wrote:
> On Tue, Jan 11, 2011 at 10:40:51AM +0000, Russell King - ARM Linux wrote:
> > On Mon, Jan 10, 2011 at 07:15:53PM -0700, Grant Likely wrote:
> > > diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S
> > > index 6bd82d2..9c0e938 100644
> > > --- a/arch/arm/kernel/head.S
> > > +++ b/arch/arm/kernel/head.S
> > > @@ -87,11 +87,6 @@ ENTRY(stext)
> > > movs r10, r5 @ invalid processor (r5=0)?
> > > THUMB( it eq ) @ force fixup-able long branch encoding
> > > beq __error_p @ yes, error 'p'
> > > - bl __lookup_machine_type @ r5=machinfo
> > > - movs r8, r5 @ invalid machine (r5=0)?
> > > - THUMB( it eq ) @ force fixup-able long branch encoding
> > > - beq __error_a @ yes, error 'a'
> > > - bl __vet_atags
> > > #ifdef CONFIG_SMP_ON_UP
> > > bl __fixup_smp
> > > #endif
> >
> > Don't forget to update the comments as well - there's two of them.
>
> I'm not entirely clear on what you're referring to here. Are you
> talking about the secondary cpu entry point? I've fixed up that
> comment now as well as a s/__lookup_machine_type/__lookup_processor_type/
> typo right before the call to __enable_mmu.
In the above code, __lookup_machine_type is called, which to be
consistent with __lookup_processor_type, returns its value in r5. This
is then copied to r8, which is the only point that r8 is initialized.
The remainder of the code used to make use of r8 to load various fields
from the machine record, and so there's a couple of comments indicating
that this is the case. These comments are left behind after your patch
and so are misleading.
Shall I assume that you've already searched the head*.S files to make
sure that r8 isn't used before you removed its initialization? ;-)
next prev parent reply other threads:[~2011-01-11 15:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 2:15 [RFC] arm: Defer lookup of machine_type and vet of atags to setup.c Grant Likely
2011-01-11 3:19 ` Nicolas Pitre
2011-01-11 5:21 ` Grant Likely
2011-01-11 10:40 ` Russell King - ARM Linux
2011-01-11 15:36 ` Grant Likely
2011-01-11 15:48 ` Russell King - ARM Linux [this message]
2011-01-12 15:46 ` Grant Likely
2011-01-12 15:52 ` Russell King - ARM Linux
2011-01-12 16:24 ` Grant Likely
2011-01-12 16:32 ` Russell King - ARM Linux
2011-01-12 16:53 ` Nicolas Pitre
2011-01-12 17:16 ` Grant Likely
2011-01-12 17:25 ` Russell King - ARM Linux
2011-01-12 17:49 ` Grant Likely
2011-02-07 15:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111154833.GF11039@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=grant.likely@secretlab.ca \
--cc=jeremy.kerr@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.pitre@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).