From: Kees Cook <kees.cook@canonical.com>
To: linux-kernel@vger.kernel.org
Cc: Brad Spengler <spender@grsecurity.net>,
Vasiliy Kulikov <segooon@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org Joerg Reuter" <jreuter@yaina.de>,
Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] net: ax25: fix information leak to userland harder
Date: Tue, 11 Jan 2011 21:40:22 -0800 [thread overview]
Message-ID: <20110112054022.GR4979@outflux.net> (raw)
Commit fe10ae53384e48c51996941b7720ee16995cbcb7 adds a memset() to clear
the structure being sent back to userspace, but accidentally used the
wrong size.
Reported-by: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Kees Cook <kees.cook@canonical.com>
Cc: stable@kernel.org
---
net/ax25/af_ax25.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index bb86d29..6da5dae 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -1392,7 +1392,7 @@ static int ax25_getname(struct socket *sock, struct sockaddr *uaddr,
ax25_cb *ax25;
int err = 0;
- memset(fsa, 0, sizeof(fsa));
+ memset(fsa, 0, sizeof(*fsa));
lock_sock(sk);
ax25 = ax25_sk(sk);
--
1.7.2.3
--
Kees Cook
Ubuntu Security Team
next reply other threads:[~2011-01-12 5:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 5:40 Kees Cook [this message]
2011-01-12 8:34 ` [PATCH] net: ax25: fix information leak to userland harder David Miller
2011-01-12 8:35 ` David Miller
2011-01-12 14:01 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112054022.GR4979@outflux.net \
--to=kees.cook@canonical.com \
--cc=davem@davemloft.net \
--cc=jreuter@yaina.de \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=segooon@gmail.com \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox