From: Rusty Russell <rusty@rustcorp.com.au>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH] module: fix build when DEBUGP is defined
Date: Thu, 13 Jan 2011 08:32:15 +1030 [thread overview]
Message-ID: <201101130832.16210.rusty@rustcorp.com.au> (raw)
In-Reply-To: <4D2DD629.1080701@oracle.com>
On Thu, 13 Jan 2011 02:56:17 am Randy Dunlap wrote:
> On 01/12/11 00:48, Rusty Russell wrote:
> > On Wed, 12 Jan 2011 11:51:53 am Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> Fix module loader build when DEBUGP is defined.
> >> Fixes build error & warning:
> >>
> >> kernel/module.c:1910: error: 'name' undeclared (first use in this function)
> >> kernel/module.c:2567: warning: format '%lx' expects type 'long unsigned int', but argument 2 has type 'Elf64_Addr'
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >> Cc: Rusty Russell <rusty@rustcorp.com.au>
> >> ---
> >> kernel/module.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> --- linux-next-20110111.orig/kernel/module.c
> >> +++ linux-next-20110111/kernel/module.c
> >> @@ -1907,7 +1907,7 @@ static void layout_sections(struct modul
> >> || strstarts(sname, ".init"))
> >> continue;
> >> s->sh_entsize = get_offset(mod, &mod->core_size, s, i);
> >> - DEBUGP("\t%s\n", name);
> >> + DEBUGP("\t%s\n", sname);
> >> }
> >> switch (m) {
> >> case 0: /* executable */
> >> @@ -2563,7 +2563,7 @@ static int move_module(struct module *mo
> >> memcpy(dest, (void *)shdr->sh_addr, shdr->sh_size);
> >> /* Update sh_addr to point to copy in image. */
> >> shdr->sh_addr = (unsigned long)dest;
> >> - DEBUGP("\t0x%lx %s\n",
> >> + DEBUGP("\t0x%llx %s\n",
> >> shdr->sh_addr, info->secstrings + shdr->sh_name);
> >
> > This will break on 32-bit. We really need a cast to long here :(
>
> Really? I built it on i386 and x86_64 (successfully).
shdr->sh_addr is 32 bit, not a long long. You should get a warning.
Rusty.
next prev parent reply other threads:[~2011-01-12 22:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 1:21 [PATCH] module: fix build when DEBUGP is defined Randy Dunlap
2011-01-12 8:48 ` Rusty Russell
2011-01-12 16:26 ` Randy Dunlap
2011-01-12 22:02 ` Rusty Russell [this message]
2011-01-13 0:12 ` [PATCH v2] " Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101130832.16210.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox