public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: "Stephane Eranian" <eranian@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	mingo@elte.hu, "Robert Richter" <robert.richter@amd.com>
Subject: Re: [BUG] perf sched broken
Date: Thu, 13 Jan 2011 11:20:03 -0200	[thread overview]
Message-ID: <20110113132003.GA17903@ghostprotocols.net> (raw)
In-Reply-To: <4D2E5B33.2080305@linux.vnet.ibm.com>

Em Wed, Jan 12, 2011 at 05:53:55PM -0800, Corey Ashford escreveu:
> On 01/12/2011 01:29 AM, Stephane Eranian wrote:
>> Hi,
>>
>> I am trying to use perf sched from tip-x86 but it fails for all my attempts.
>>
>> First of, I think the event list is stale. This is not so much the
>> events themselves
>> but rather the flags.
>>
>> Looks to me like the :r modifier is not supported anymore, so a patch like the
>> one below is needed. That helps collect a trace. But then, you can dump
>> the trace.
>
> After looking at this in more detail, I agree with Stephane: the 'r'  
> option appears to only be supported for hardware breakpoint events.  My  
> patch just causes the 'r' to be properly processed and rejected as a  
> legal option.

And thus broke 'perf sched' because it uses it, thanks to this
discussion we figured out that 'perf sched' shouldn't be using it :)

So thank you and Stephane, I'm applying his patch. That ':r' stuff makes
no sense and I couldn't find it being parsed anywhere, historical
bitrotted baggage it seems.

Thanks a lot!

- Arnaldo

  reply	other threads:[~2011-01-13 13:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12  9:29 [BUG] perf sched broken Stephane Eranian
2011-01-12 12:11 ` Arnaldo Carvalho de Melo
2011-01-12 19:10   ` Corey Ashford
2011-01-12 19:41 ` Corey Ashford
2011-01-12 19:52   ` Stephane Eranian
2011-01-12 20:22     ` Corey Ashford
2011-01-12 22:35 ` Corey Ashford
2011-01-12 22:38   ` Stephane Eranian
2011-01-13  1:53 ` Corey Ashford
2011-01-13 13:20   ` Arnaldo Carvalho de Melo [this message]
2011-01-14  7:25 ` [tip:perf/urgent] perf sched: Fix list of events, dropping unsupported ':r' modifier tip-bot for Stephane Eranian
2011-08-03 10:59   ` Peter Zijlstra
2011-08-03 11:37     ` Frederic Weisbecker
2011-08-03 11:42       ` Peter Zijlstra
2011-08-03 11:57         ` Frederic Weisbecker
2011-08-03 12:05           ` Peter Zijlstra
2011-08-03 12:11             ` Frederic Weisbecker
2011-08-03 12:18               ` Peter Zijlstra
2011-08-03 17:06                 ` Arnaldo Carvalho de Melo
2011-08-03 19:49                   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110113132003.GA17903@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox