From: Greg KH <greg@kroah.com>
To: Sutharsan Ramamoorthy <sutharsan.ramamoorthy@yahoo.com>
Cc: tony@atomide.com, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
david.cross@cypress.com, srmt@cypress.com
Subject: Re: [PATCH] adding gpmc configuration functions, west bridge related
Date: Thu, 13 Jan 2011 15:44:28 -0800 [thread overview]
Message-ID: <20110113234428.GA17904@kroah.com> (raw)
In-Reply-To: <524702.86777.qm@web121609.mail.ne1.yahoo.com>
On Thu, Jan 13, 2011 at 03:23:14PM -0800, Sutharsan Ramamoorthy wrote:
> This patch implements gpmc configuration functions needed by westbridge
> device controller driver in staging tree. These functions currently
> implemented in staging tree. This patch is part of the effort to bring
> westbridge device controller driver out of staging tree.
>
> Signed-off by: Sutharsan Ramamoorthy <sutharsan.ramamoorthy@yahoo.com>
Close, but not quite.
Why remove your cypress.com email address here? That's who really is
"signing off" on this patch, right?
Also, please note my previous comments about "lots more needs to be done
to the driver before this can even start to move out of the staging
tree". Moving these functions should be one of the _last_ things that
happens, not the first.
Please work on cleaning up the code in the drivers/staging/westbridge/
directory first. When that is all done, _then_ we can start moving it
out.
Ok?
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-13 23:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 23:23 [PATCH] adding gpmc configuration functions, west bridge related Sutharsan Ramamoorthy
2011-01-13 23:44 ` Greg KH [this message]
2011-01-14 20:01 ` Tony Lindgren
[not found] <AANLkTim-1+CwW50mPwi6DnQDF680fxjJms7JrEPqsqkv@mail.gmail.com>
2011-01-12 21:36 ` Greg KH
2011-01-12 21:37 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-12-21 2:42 Sutharsan R
2010-12-21 4:11 ` Greg KH
2010-12-21 20:46 ` Tony Lindgren
2010-12-17 0:33 Sutharsan
2010-12-17 0:41 ` Greg KH
2010-12-15 19:57 Sutharsan
2010-12-15 20:10 ` Greg KH
2010-12-15 22:11 ` Sutharsan
2010-12-15 22:18 ` Greg KH
2010-12-15 23:03 ` Sutharsan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113234428.GA17904@kroah.com \
--to=greg@kroah.com \
--cc=david.cross@cypress.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srmt@cypress.com \
--cc=sutharsan.ramamoorthy@yahoo.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox