From: David Miller <davem@davemloft.net>
To: richm@oldelvet.org.uk
Cc: sparclinux@vger.kernel.org, fberckel@xs4all.nl,
julian.calaby@gmail.com, sinan@writeme.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] cassini: Use local-mac-address prom property for Cassini MAC address
Date: Fri, 14 Jan 2011 12:40:53 -0800 (PST) [thread overview]
Message-ID: <20110114.124053.111572121.davem@davemloft.net> (raw)
In-Reply-To: <4D3035F0.6020503@oldelvet.org.uk>
From: Richard Mortimer <richm@oldelvet.org.uk>
Date: Fri, 14 Jan 2011 11:39:28 +0000
> FYI Sinan Akman has reported that cassini does not compile for x86 any
> longer. Message included below.
>
> Does anyone have suggestions as to the best way to resolve this?
I'll fix it like this:
--------------------
cassini: Fix build bustage on x86.
Unfortunately, not all CONFIG_OF platforms provide
pci_device_to_OF_node().
Change the test to CONFIG_SPARC for now to deal with
the build regressions.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/cassini.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 7206ab2..3437613 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -3203,7 +3203,7 @@ static int cas_get_vpd_info(struct cas *cp, unsigned char *dev_addr,
int phy_type = CAS_PHY_MII_MDIO0; /* default phy type */
int mac_off = 0;
-#if defined(CONFIG_OF)
+#if defined(CONFIG_SPARC)
const unsigned char *addr;
#endif
@@ -3354,7 +3354,7 @@ use_random_mac_addr:
if (found & VPD_FOUND_MAC)
goto done;
-#if defined(CONFIG_OF)
+#if defined(CONFIG_SPARC)
addr = of_get_property(cp->of_node, "local-mac-address", NULL);
if (addr != NULL) {
memcpy(dev_addr, addr, 6);
@@ -5031,7 +5031,7 @@ static int __devinit cas_init_one(struct pci_dev *pdev,
cp->msg_enable = (cassini_debug < 0) ? CAS_DEF_MSG_ENABLE :
cassini_debug;
-#if defined(CONFIG_OF)
+#if defined(CONFIG_SPARC)
cp->of_node = pci_device_to_OF_node(pdev);
#endif
--
1.7.3.4
next parent reply other threads:[~2011-01-14 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1294324455.6193.70.camel@duncow>
[not found] ` <20110106.115123.35031451.davem@davemloft.net>
[not found] ` <4D3035F0.6020503@oldelvet.org.uk>
2011-01-14 20:40 ` David Miller [this message]
2011-01-15 8:47 ` [PATCH v3] cassini: Use local-mac-address prom property for Cassini MAC address Richard Mortimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114.124053.111572121.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fberckel@xs4all.nl \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richm@oldelvet.org.uk \
--cc=sinan@writeme.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox