From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481Ab1ANOja (ORCPT ); Fri, 14 Jan 2011 09:39:30 -0500 Received: from void.printf.net ([89.145.121.20]:39488 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539Ab1ANOjX (ORCPT ); Fri, 14 Jan 2011 09:39:23 -0500 Date: Fri, 14 Jan 2011 14:39:22 +0000 From: Chris Ball To: Michal Marek Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: sdhci-of does not build on x86 Message-ID: <20110114143922.GA29486@void.printf.net> References: <1295008191-1596-1-git-send-email-mmarek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1295008191-1596-1-git-send-email-mmarek@suse.cz> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, On Fri, Jan 14, 2011 at 01:29:51PM +0100, Michal Marek wrote: > After commit c10d1e2, CONFIG_OLPC selects CONFIG_OF, which enables to > select CONFIG_MMC_SDHCI_OF, which does not build on x86: > > drivers/mmc/host/sdhci-of-core.c:24:25: fatal error: asm/machdep.h: No > such file or directory > > Signed-off-by: Michal Marek > --- > > I don't know if the driver could possibly work on some OLPC hardware, > but it wasn't used on x86 before, so this patch won't make things any worse. Thanks very much for the patch, but Grant Likely already has a different one queued that he's going to push to Linus, so we'll use that. -- Chris Ball One Laptop Per Child