From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752339Ab1APXHz (ORCPT ); Sun, 16 Jan 2011 18:07:55 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:37803 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751867Ab1APXHv (ORCPT ); Sun, 16 Jan 2011 18:07:51 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Date: Mon, 17 Jan 2011 00:06:59 +0100 From: Stefan Richter To: "Nicholas A. Bellinger" Cc: Linus Torvalds , linux-kernel , linux-scsi , linux-fsdevel , Joel Becker , Randy Dunlap , James Bottomley Subject: Re: [PATCH] configfs: change depends -> select SYSFS Message-ID: <20110117000659.57352da7@stein> In-Reply-To: <1295214807.22813.57.camel@haakon2.linux-iscsi.org> References: <1295125851-25279-1-git-send-email-nab@linux-iscsi.org> <20110116141105.59e5b3a2@stein> <1295214807.22813.57.camel@haakon2.linux-iscsi.org> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jan 16 Nicholas A. Bellinger wrote: > On Sun, 2011-01-16 at 14:11 +0100, Stefan Richter wrote: > > On Jan 15 Nicholas A. Bellinger wrote: > > > This patch changes configfs to select SYSFS to fix the following: > > > > > > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS) > > > > Why don't you fix target-core's Kconfig instead? > > The thought here was that since modern configfs is mounted > at /sys/kernel/config/, selecting SYSFS by default when building > CONFIGFS_FS made the most sense for existing configfs consumers. I for one think that layered "select" directives will open too many cans of worms. Best don't use select at all. If you use it, select only options that don't depend on anything else. If you feel that people really want you to provide a select for them which selects something that in turn depends on other things, then I suggest you rather let your own option depend on these lower dependencies: config HIGHLEVEL_FEATURE tristate "some driver" depends on SYSFS # because CONFIGFS depends on it select CONFIGFS -- Stefan Richter -=====-==-== ---= =---= http://arcgraph.de/sr/