From: Stephen Hemminger <shemminger@vyatta.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andres Salomon <dilinger@queued.net>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Dan Carpenter <error27@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
devel@driverdev.osuosl.org,
"David S.Miller" <davem@davemloft.net>
Subject: Re: [PATCH] staging: fix build failure in bcm driver
Date: Mon, 17 Jan 2011 09:29:59 -0800 [thread overview]
Message-ID: <20110117092959.72b166af@nehalam> (raw)
In-Reply-To: <1295074306.3977.11.camel@edumazet-laptop>
On Sat, 15 Jan 2011 07:51:45 +0100
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le vendredi 14 janvier 2011 à 17:24 -0800, Andres Salomon a écrit :
> > While building, I hit the following:
> >
> > CC [M] drivers/staging/bcm/Qos.o
> > drivers/staging/bcm/Qos.c: In function ‘PruneQueue’:
> > drivers/staging/bcm/Qos.c:367: error: ‘struct netdev_queue’ has no member named ‘tx_dropped’
> > drivers/staging/bcm/Qos.c: In function ‘flush_all_queues’:
> > drivers/staging/bcm/Qos.c:416: error: ‘struct netdev_queue’ has no member named ‘tx_dropped’
> > make[5]: *** [drivers/staging/bcm/Qos.o] Error 1
> > make[4]: *** [drivers/staging/bcm] Error 2
> > make[3]: *** [drivers/staging] Error 2
> >
> > As well as:
> >
> > CC [M] drivers/staging/bcm/Transmit.o
> > drivers/staging/bcm/Transmit.c: In function ‘SetupNextSend’:
> > drivers/staging/bcm/Transmit.c:163: error: ‘struct netdev_queue’ has no member named ‘tx_bytes’
> > drivers/staging/bcm/Transmit.c:164: error: ‘struct netdev_queue’ has no member named ‘tx_packets’
> > make[2]: *** [drivers/staging/bcm/Transmit.o] Error 1
> >
> >
> > tx_dropped/tx_bytes_tx_packets were removed in commit 1ac9ad13. This patch
> > converts bcm to use net_device_stats instead of netdev_queue.
> >
> > Signed-off-by: Andres Salomon <dilinger@queued.net>
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> BTW, chunks included in this patch have horrible codingstyle.
>
> Is this driver planned for inclusion sometime ?
>
Looks like the "remove dev_txq_stats_fold" patch missed the staging driver(s).
The bcm driver code is gross, the driver should be rewritten see the TODO.
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
prev parent reply other threads:[~2011-01-17 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110114172439.65d6d557@queued.net>
[not found] ` <20110114173713.2d89e43c@nehalam>
2011-01-15 1:50 ` [PATCH] staging: fix build failure in bcm driver Andres Salomon
2011-01-15 6:51 ` Eric Dumazet
2011-01-17 17:29 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117092959.72b166af@nehalam \
--to=shemminger@vyatta.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dilinger@queued.net \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox