From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753367Ab1ARIGJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 18 Jan 2011 03:06:09 -0500
Received: from mx2.mail.elte.hu ([157.181.151.9]:33182 "EHLO mx2.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753151Ab1ARIGF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 18 Jan 2011 03:06:05 -0500
Date: Tue, 18 Jan 2011 09:05:54 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        "hpa@zytor.com" <hpa@zytor.com>, "Lu, Hongjiu" <hongjiu.lu@intel.com>,
        "Huang, Ying" <ying.huang@intel.com>
Subject: Re: [PATCH]x86: make relocatable kernel work with new binutils
 -resend
Message-ID: <20110118080554.GB18317@elte.hu>
References: <1295232361.1949.675.camel@sli10-conroe>
 <20110117101756.GB26819@elte.hu>
 <1295312269.1949.725.camel@sli10-conroe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1295312269.1949.725.camel@sli10-conroe>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-ELTE-SpamScore: -2.0
X-ELTE-SpamLevel: 
X-ELTE-SpamCheck: no
X-ELTE-SpamVersion: ELTE 2.0 
X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5
	-2.0 BAYES_00               BODY: Bayesian spam probability is 0 to 1%
	[score: 0.0000]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Shaohua Li <shaohua.li@intel.com> wrote:

> On Mon, 2011-01-17 at 18:17 +0800, Ingo Molnar wrote:
> > * Shaohua Li <shaohua.li@intel.com> wrote:
> > 
> > > @@ -142,6 +140,11 @@ SECTIONS
> > >  		CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
> > >  
> > >  		DATA_DATA
> > > +#ifdef CONFIG_X86_32
> > > +		jiffies = jiffies_64;
> > > +#else
> > > +		jiffies_64 = jiffies;
> > > +#endif
> > 
> > I suspect this needs a comment, as to the unsuspecting reader it looks like black 
> > magic :-)
>
> does this one look better?

Yeah, thanks!

	Ingo