From: Don Zickus <dzickus@redhat.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
stable@kernel.org
Subject: Re: [PATCH 1/3] watchdog: fix broken nowatchdog logic
Date: Tue, 18 Jan 2011 19:23:40 -0500 [thread overview]
Message-ID: <20110119002340.GB31465@redhat.com> (raw)
In-Reply-To: <1295390266-9347-1-git-send-email-marcin.slusarz@gmail.com>
On Tue, Jan 18, 2011 at 11:37:44PM +0100, Marcin Slusarz wrote:
> Passing nowatchdog to kernel disables 2 things: creation of watchdog threads
> AND initialization of percpu watchdog_hrtimer. As hrtimers are initialized
> only at boot it's not possible to enable watchdog later - for me all watchdog
> threads started to eat 100% of CPU time, but they could just crash.
>
> Additionally, even if these threads would start properly,
> watchdog_disable_all_cpus was guarded by no_watchdog check, so you
> couldn't disable watchdog.
>
> To fix this, remove no_watchdog variable and use already existing
> watchdog_enabled variable.
These three patches seem reasonable. I'll queue them up.
Thanks,
Don
next prev parent reply other threads:[~2011-01-19 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 22:37 [PATCH 1/3] watchdog: fix broken nowatchdog logic Marcin Slusarz
2011-01-19 0:23 ` Don Zickus [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-28 16:00 [PATCH 1/3] watchdog: Fix " Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119002340.GB31465@redhat.com \
--to=dzickus@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=mingo@elte.hu \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox