From: Greg KH <greg@kroah.com>
To: Sutharsan Ramamoorthy <sutharsan.ramamoorthy@yahoo.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
david.cross@cypress.com, srmt@cypress.com
Subject: Re: [PATCH] Westbridge software module, fixes errors reported by checkpatch.pl
Date: Tue, 18 Jan 2011 20:31:27 -0800 [thread overview]
Message-ID: <20110119043127.GC25787@kroah.com> (raw)
In-Reply-To: <792204.57037.qm@web121606.mail.ne1.yahoo.com>
On Mon, Jan 17, 2011 at 03:59:09PM -0800, Sutharsan Ramamoorthy wrote:
> From: Sutharsan Ramamoorthy <srmt@cypress.com>
>
> This patch fixes errors in westbridge device controller driver in the
> staging tree reported by checkpatch.pl. File containing EXPORT_SYMBOL()
> macros for all the API's exported by the westbridge software has been
> removed. EXPORT_SYMBOL() macro's are added after the functions being
> exported. This patch also fixes some function prototype definitions and
> removes new typdefs.
Care to split this into two patches? Every patch should only do one
thing at a time.
> +struct cyasdevice {
> /* Handle to the Antioch device */
> cy_as_device_handle dev_handle;
> /* Handle to the HAL */
> cy_as_hal_device_tag hal_tag;
> spinlock_t common_lock;
> unsigned long flags;
> -} cyasdevice;
> +} ;
What's with the extra space here?
thanks,
greg k-h
next prev parent reply other threads:[~2011-01-19 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 23:59 [PATCH] Westbridge software module, fixes errors reported by checkpatch.pl Sutharsan Ramamoorthy
2011-01-19 4:31 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-20 1:31 Sutharsan Ramamoorthy
2011-01-21 20:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119043127.GC25787@kroah.com \
--to=greg@kroah.com \
--cc=david.cross@cypress.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=srmt@cypress.com \
--cc=sutharsan.ramamoorthy@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox