From: Andrew Morton <akpm@linux-foundation.org>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Tejun Heo <tj@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
James Morris <jmorris@namei.org>,
Kees Cook <kees.cook@canonical.com>,
Namhyung Kim <namhyung@gmail.com>
Subject: Re: [Patch] printk: move some loglevel setup functions to kernel/printk.c
Date: Wed, 19 Jan 2011 12:18:55 -0800 [thread overview]
Message-ID: <20110119121855.c529f84f.akpm@linux-foundation.org> (raw)
In-Reply-To: <1295422165-22269-1-git-send-email-amwang@redhat.com>
> Cc: WANG Cong <amwang@redhat.com>, Ingo Molnar <mingo@elte.hu> (commit_signer:8/43=19%,commit_signer:4/26=15%), Andrew Morton <akpm@linux-foundation.org> (commit_signer:7/43=16%,commit_signer:9/26=35%), Peter Zijlstra <a.p.zijlstra@chello.nl> (commit_signer:5/43=12%), Tejun Heo <tj@kernel.org> (commit_signer:4/43=9%), Arnd Bergmann <arnd@arndb.de> (commit_signer:3/43=7%), James Morris <jmorris@namei.org> (commit_signer:6/26=23%), Kees Cook <kees.cook@canonical.com> (commit_signer:4/26=15%), Namhyung Kim <namhyung@gmail.com> (commit_signer:3/26=12%)
Pease don't do that.
On Wed, 19 Jan 2011 15:29:24 +0800
Amerigo Wang <amwang@redhat.com> wrote:
> These parameter setup functions should go to kernel/printk.c,
That makes sense.
> and should also be under CONFIG_PRINTK.
Not so sure about that. console_loglevel pertains to the console
system more than to printk. And the console layer is present even when
CONFIG_PRINTK=n.
Now, it may be that console_loglevel never does anything useful when
CONFIG_PRINTK=n. In which case one wonders why the console code exists
when CONFIG_PRINTK=n.
Anyway. I didn't look at all this terribly hard. Please demonstrate
to us that you did do so :)
next prev parent reply other threads:[~2011-01-19 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 7:29 [Patch] printk: move some loglevel setup functions to kernel/printk.c Amerigo Wang
2011-01-19 20:18 ` Andrew Morton [this message]
2011-01-20 7:36 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119121855.c529f84f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=amwang@redhat.com \
--cc=arnd@arndb.de \
--cc=jmorris@namei.org \
--cc=kees.cook@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox