From: Arnd Bergmann <arnd@arndb.de>
To: Nick Bowler <nbowler@elliptictech.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] BKL: move CONFIG_BKL to staging
Date: Wed, 19 Jan 2011 17:17:58 +0100 [thread overview]
Message-ID: <201101191717.58277.arnd@arndb.de> (raw)
In-Reply-To: <20110119154419.GA21411@elliptictech.com>
On Wednesday 19 January 2011, Nick Bowler wrote:
> I think this patch is not very nice. It will cause working kernel
> configurations to turn into broken kernel configurations when the user
> does 'make oldconfig', with no warning.
>
> These drivers that use the BKL work fine. Removing working features
> with no adequate replacement available seems like a serious regression
> to me.
I wouldn't call it a serious regression since the code is still there
and both the symptom and the solution are rather obvious. What's more
important is to make any people still relying on the code aware that
it's going away unless someone fixes it, so they have the chance to
send patches or pay someone to fix it for them.
The remaining drivers that are still relying on the BKL are very
rarely used and for the less obscure ones (ufs, ipx and x.25), people
have volunteered to fix them (though I have seen no proper patches
for these yet). For the rest, I suppose if nobody complains, they
can actually go away, according to the logic that if nobody is using
them, they most likely are broken anyway and more a security risk than
they are worth.
Anyway, it seems that you're lucky this time, because I managed to miss
the merge window by being away from my test box for the most part of it.
Arnd
next prev parent reply other threads:[~2011-01-19 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 21:16 [PATCH 0/4] Phasing out the BKL Arnd Bergmann
2011-01-18 21:16 ` [PATCH 1/4] drm/i810: remove " Arnd Bergmann
2011-01-18 21:17 ` [PATCH 2/4] BKL: disable by default Arnd Bergmann
2011-01-18 21:17 ` [PATCH 3/4] BKL: mark lock_kernel as deprecated Arnd Bergmann
2011-01-18 21:17 ` [PATCH 4/4] BKL: move CONFIG_BKL to staging Arnd Bergmann
2011-01-19 15:44 ` Nick Bowler
2011-01-19 16:17 ` Arnd Bergmann [this message]
2011-01-19 18:21 ` Nick Bowler
2011-01-23 22:19 ` Andrew Hendry
[not found] ` <AANLkTimOzU328aHnB7+ERSq1ovPBSZgxNQsYRhLghH5L@mail.gmail.com>
2011-01-24 15:59 ` Arnd Bergmann
2011-01-25 0:33 ` Andrew Hendry
2011-01-25 12:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101191717.58277.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=nbowler@elliptictech.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox