RE: [PATCH v2 1/1]mmc: implemented eMMC4.4 enhanced area feature

Dong, Chuanxiao
2011-01-20T06:55:33Z

Hi Chris,
>
> On Thu, Jan 20, 2011 at 02:08:04PM +0800, Dong, Chuanxiao wrote:
> > > I think these should probably be printed in decimal instead of hex.
>
> (Will assume you agree with this, let me know if not.)
Agree with this. Sorry for missing it.

>
> > > Hm, this way the sysfs files will show up regardless of whether we have
> > > an eMMC device or an SD card, which is very confusing. Can you not check
> > > whether enhanced_area_en == 1 before create these files?
> > >
> > SD card will not use this code when initializing. So I think these files only are
> created for eMMC card. If the eMMC card doesn't support enhanced area, can we
> use the same way like below scenario, exporting some value like -EINVAL to user?
> What do you think?
>
> Oh, makes sense -- I agree, let's just use -EINVAL, and update the sysfs
> ABI doc to mention that. Thanks!
Cool! I will fix these and then resubmit the new patch. :)

Thanks
Chuanxiao