Re: [PATCH 3/3] mmc: remove anti clock gating quirk for wl1271

Chris Ball
2011-01-20T04:14:15Z

Hi Pierre,

On Sun, Jan 09, 2011 at 05:26:20PM +0100, Pierre Tardy wrote:
> From: Pierre Tardy <pierre.tardy@intel.com>
>
> Signed-off-by: Pierre Tardy <pierre.tardy@intel.com>
> ---
> drivers/mmc/core/quirks.c | 18 ++++++++++++++++++
> 1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/quirks.c b/drivers/mmc/core/quirks.c
> index fe467c8..506e4fc 100644
> --- a/drivers/mmc/core/quirks.c
> +++ b/drivers/mmc/core/quirks.c
> @@ -33,6 +33,14 @@ static void add_quirk(struct mmc_card *card, int data)
> }
>
> /*
> + * This hook just removes a quirk unconditionnally
> + */
> +static void remove_quirk_hook(struct mmc_card *card, int data)
> +{
> + card->quirks &= ~data;
> +}

This adds a defined-but-not-used warning. The MMC tree doesn't
currently generate any warnings, so it would be good to avoid adding new
ones, though I understand why it might make sense in this case.

drivers/mmc/core/quirks.c:30:13: warning: ‘add_quirk’ defined but not used
drivers/mmc/core/quirks.c:38:13: warning: ‘remove_quirk_hook’ defined but not used

> +
> +/*
> * This hook just adds a quirk for all sdio devices
> */
> static void add_quirk_for_sdio_devices(struct mmc_card *card, int data)
> @@ -41,9 +49,19 @@ static void add_quirk_for_sdio_devices(struct mmc_card *card, int data)
> card->quirks |= data;
> }
>
> +#ifndef SDIO_VENDOR_ID_TI
> +#define SDIO_VENDOR_ID_TI 0x0097
> +#endif
> +
> +#ifndef SDIO_DEVICE_ID_TI_WL1271
> +#define SDIO_DEVICE_ID_TI_WL1271 0x4076
> +#endif
> +
> static const struct mmc_fixup mmc_fixup_methods[] = {
> { SDIO_ANY_ID, SDIO_ANY_ID,
> add_quirk_for_sdio_devices, MMC_QUIRK_BROKEN_CLK_GATING }
> + { SDIO_VENDOR_ID_TI, SDIO_DEVICE_ID_TI_WL1271,
> + remove_quirk_hook, MMC_QUIRK_BROKEN_CLK_GATING },
> { 0 }
> };
>

This doesn't compile, missing a comma. Was it tested?

drivers/mmc/core/quirks.c:63:2: error: expected ‘}’ before ‘{’ token

(Otherwise, looks good.)

--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child