From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@cs.helsinki.fi>
Subject: Re: [PATCH 1/2] lockdep: move early boot local IRQ enable/disable status to init/main.c
Date: Thu, 20 Jan 2011 12:26:06 +0100 [thread overview]
Message-ID: <20110120112606.GF6036@htj.dyndns.org> (raw)
In-Reply-To: <1295522631.28776.155.camel@laptop>
On Thu, Jan 20, 2011 at 12:23:51PM +0100, Peter Zijlstra wrote:
> On Thu, 2011-01-20 at 12:11 +0100, Tejun Heo wrote:
> > Hello, guys.
> >
> > These two patches remove both warnings. The first warning was
> > completely spurious. The second lockdep one was triggered by
> > on_each_cpu() enabling local IRQ too early.
> >
> > I don't think percpu allocator itself malfunctioned. There was no
> > allocation failure. It whines when percpu allocation fails but didn't
> > in the log. Other than calling vfree() early triggering the above
> > condition, it worked okay.
> >
> > So, it's either the early enabling of local IRQ by on_each_cpu()
> > breaking something in the IRQ subsystem or something different. Ingo,
> > can you please see whether these two patches cure the panic too?
>
> Why not use something like: system_state != SYSTEM_RUNNING ?
Cuz, it's finer grained than that. We can add a SYSTEM_* flag but I
wasn't sure whether that would be just creating more noise. If we try
to consolidate these things, we probably should consider
oops_in_progress too. It probably is a good idea but let's first fix
the problem at hand.
Thanks.
--
tejun
next prev parent reply other threads:[~2011-01-20 11:26 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 23:54 Linux 2.6.38-rc1 Linus Torvalds
2011-01-19 2:07 ` Linus Torvalds
2011-01-19 3:42 ` Justin Mattock
2011-01-19 3:53 ` Linus Torvalds
2011-01-19 4:05 ` Justin Mattock
2011-01-19 5:10 ` nobody
2011-01-19 5:42 ` Linus Torvalds
2011-01-19 5:56 ` Linus Torvalds
2011-01-19 18:07 ` Steven Rostedt
2011-01-19 18:26 ` Linus Torvalds
2011-01-21 3:23 ` tag&track [Re: Linux 2.6.38-rc1] nobody
2011-01-21 8:24 ` Alexey Dobriyan
2011-01-23 8:13 ` Linux 2.6.38-rc1 Török Edwin
2011-01-19 7:39 ` Linux 2.6.38-rc1 doesn't boot Markus Trippelsdorf
2011-01-19 7:46 ` Shaohua Li
2011-01-19 7:55 ` Markus Trippelsdorf
2011-01-19 7:49 ` Markus Trippelsdorf
2011-01-19 8:12 ` Shaohua Li
2011-01-19 8:56 ` H. Peter Anvin
2011-01-19 9:09 ` Ingo Molnar
2011-01-20 2:08 ` Shaohua Li
2011-01-20 3:32 ` Lu, Hongjiu
2011-01-20 11:25 ` Ingo Molnar
2011-01-20 15:08 ` Anvin, H Peter
2011-01-21 7:18 ` Shaohua Li
2011-01-21 7:55 ` Shaohua Li
2011-01-21 15:28 ` H. Peter Anvin
2011-01-21 15:37 ` Lu, Hongjiu
2011-01-21 21:09 ` Ingo Molnar
2011-01-19 9:33 ` [tip:x86/urgent] Revert "x86: Make relocatable kernel work with new binutils" tip-bot for Ingo Molnar
2011-01-20 4:59 ` Linux 2.6.38-rc1 doesn't boot Alexandre Courbot
2011-01-19 8:39 ` PPS parport boot lockup: INFO: HARDIRQ-READ-safe -> HARDIRQ-READ-unsafe lock order detected Ingo Molnar
2011-01-20 13:04 ` Alexander Gordeev
2011-01-21 14:44 ` Alexander Gordeev
2011-01-21 16:37 ` Linus Torvalds
2011-01-21 19:43 ` Ingo Molnar
2011-01-24 23:28 ` Alexander Gordeev
2011-01-24 23:46 ` [PATCH] pps: claim parallel port exclusively Alexander Gordeev
2011-01-25 0:19 ` Ingo Molnar
2011-01-24 15:00 ` PPS parport boot lockup: INFO: HARDIRQ-READ-safe -> HARDIRQ-READ-unsafe lock order detected Alexander Gordeev
2011-01-24 15:12 ` [PATCH] parport: make lockdep happy with waitlist_lock Alexander Gordeev
2011-01-24 15:28 ` Ingo Molnar
2011-01-24 15:33 ` Alexander Gordeev
2011-01-19 12:02 ` percpu related boot crash on x86 (was: Linux 2.6.38-rc1) Ingo Molnar
2011-01-19 12:44 ` Tejun Heo
2011-01-19 12:48 ` Peter Zijlstra
2011-01-19 12:56 ` Pekka Enberg
2011-01-19 13:12 ` Peter Zijlstra
2011-01-19 13:13 ` Tejun Heo
2011-01-19 20:53 ` Ingo Molnar
2011-01-19 23:11 ` Ingo Molnar
2011-01-20 8:31 ` percpu related boot crash on x86 Pekka Enberg
2011-01-20 10:47 ` Peter Zijlstra
2011-01-20 11:12 ` Eric Dumazet
2011-01-20 11:19 ` Tejun Heo
2011-01-20 11:06 ` [PATCH 1/2] lockdep: move early boot local IRQ enable/disable status to init/main.c Tejun Heo
2011-01-20 11:07 ` [PATCH 2/2] smp: allow on_each_cpu() to be called while early_boot_irqs_disabled " Tejun Heo
2011-01-20 20:22 ` [tip:core/urgent] smp: Allow " tip-bot for Tejun Heo
2011-01-20 11:11 ` [PATCH 1/2] lockdep: move early boot local IRQ enable/disable " Tejun Heo
2011-01-20 11:23 ` Peter Zijlstra
2011-01-20 11:26 ` Tejun Heo [this message]
2011-01-20 11:30 ` Pekka Enberg
2011-01-20 11:38 ` Peter Zijlstra
2011-01-20 12:00 ` Ingo Molnar
2011-01-20 12:20 ` [PATCH UPDATED " Tejun Heo
2011-01-20 11:51 ` [PATCH " Ingo Molnar
2011-01-20 20:21 ` [tip:core/urgent] lockdep: Move " tip-bot for Tejun Heo
2011-01-19 21:40 ` Linux 2.6.38-rc1 Alan Cox
2011-01-21 15:30 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120112606.GF6036@htj.dyndns.org \
--to=tj@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).