From: Greg KH <gregkh@suse.de>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Tejun Heo <tj@kernel.org>,
Ruslan Pisarev <ruslan@rpisarev.org.ua>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from pohmelfs_rename()
Date: Thu, 20 Jan 2011 07:52:28 -0800 [thread overview]
Message-ID: <20110120155228.GB28815@suse.de> (raw)
In-Reply-To: <20110120105113.GA24827@ioremap.net>
On Thu, Jan 20, 2011 at 01:51:13PM +0300, Evgeniy Polyakov wrote:
> On Thu, Jan 20, 2011 at 12:13:44AM +0300, Alexey Khoroshilov (khoroshilov@ispras.ru) wrote:
> > I do not see any reason for the mutex_unlock(&inode->i_mutex); in
> > pohmelfs_rename().
> >
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
>
> Yes, that's a bug, we already unlocked i_mutex in common path and should
> not do that on error.
>
> Thank you. Greg, please apply.
>
> > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Great, I'll queue it up with the next round of patches.
greg k-h
prev parent reply other threads:[~2011-01-20 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 21:13 [PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from pohmelfs_rename() Alexey Khoroshilov
2011-01-20 10:51 ` Evgeniy Polyakov
2011-01-20 15:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120155228.GB28815@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=ruslan@rpisarev.org.ua \
--cc=tj@kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox