From: Anisse Astier <anisse@astier.eu>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Pascal VITOUX <pascal@substantiel.fr>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jean Delvare <khali@linux-fr.org>
Subject: Re: [PATCH RFC] dmi-scan: Use little-endian for the first 3 fields of the UUID.
Date: Thu, 20 Jan 2011 18:02:38 +0100 [thread overview]
Message-ID: <20110120180238.36b8e335@destiny.ordissimo> (raw)
In-Reply-To: <201101191201.03971.bjorn.helgaas@hp.com>
Hi Bjorn,
On Wed, 19 Jan 2011 12:01:02 -0700, Bjorn Helgaas <bjorn.helgaas@hp.com> wrote :
> On Wednesday, January 19, 2011 10:54:11 am Anisse Astier wrote:
> >
> > From: Pascal VITOUX <pascal@substantiel.fr>
> >
> > - Get SMBIOS version.
> > - Byte-swap the first 3 fields of the UUID (DMI type 1) as off SMBIOS
> > version 2.6.
> >
> > This patch is an adaptation of Jean Delvare patches for dmidecode
> > rev1.100, rev1.01 and rev1.119.
> > http://cvs.savannah.gnu.org/viewvc/dmidecode/dmidecode.c?root=dmidecode&view=log
> >
> > It is intended to get the same uuid from dmidecode tool as from sysfs kernel
> > tree, more compliant with SMBIOS specification.
> > Therefore this patch will have the kernel return a different UUID if you
> > are using a recent BIOS implementing SMBIOS >= 2.6.
>
> It seems like a good idea to have /sys/class/dmi/id/product_uuid
> match what dmidecode reports. Does dmidecode use the same algorithm
> (testing dmi_ver against 0x0206)?
Yes, it does.
>
> It'd be nice to mention that /sys/... filename explicitly in the
> changelog, and maybe even include an example from a system where
> they previously did not match, and now do.
Indeed.
>
> I don't have an opinion on the SMBIOS version stuff, but that looks
> like it should be split into a separate patch.
It seems it's wrong anyway and will need more patch splitting (see Jean
Delvare's email).
Thanks for the review,
Anisse
next prev parent reply other threads:[~2011-01-20 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 17:54 [PATCH RFC] dmi-scan: Use little-endian for the first 3 fields of the UUID Anisse Astier
2011-01-19 19:01 ` Bjorn Helgaas
2011-01-20 17:02 ` Anisse Astier [this message]
2011-01-19 20:39 ` Jean Delvare
2011-01-20 17:03 ` Anisse Astier
2011-01-25 12:18 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120180238.36b8e335@destiny.ordissimo \
--to=anisse@astier.eu \
--cc=akpm@linux-foundation.org \
--cc=bjorn.helgaas@hp.com \
--cc=jbarnes@virtuousgeek.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pascal@substantiel.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox