From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: [PATCH] leds: Fix warnings when PM is disabled for BD2802
Date: Fri, 21 Jan 2011 16:23:25 -0800 [thread overview]
Message-ID: <20110121162325.c3b513bf.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110121233837.GC27943@core.coreip.homeip.net>
On Fri, 21 Jan 2011 15:38:37 -0800 Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> > That rather sucks. It leaves an all-zeroes instance of dev_pm_ops
> > uselessly bloating the driver.
>
> It is per-driver, not per device so do we really care?
We care about everything. If the objective was to make life easier for
ourselves, we'd all be on the golf course.
> > And it leaves
> > bd2802_i2c_driver.driver.pm pointing at that all-zeroes instance of
> > dev_pm_ops, which is rather dangerous.
>
> Nothing dagerous here - PM core deals with half-filled pm_ops just fine.
>
> >
> > If CONFIG_PM_SLEEP=n, the .driver.pm field shouldn't exist at all.
>
> Meh, we have _waaay_ too many config options, I'd rather see CONFIG_PM
> and possibly CONFIG_PM_SLEEP go, maybe leaving us with
> CONFIG_PM_RUNTIME and maybe not. How many devices out there do not want
> PM?
Don't know. How do we determine this?
prev parent reply other threads:[~2011-01-22 0:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 17:33 [PATCH] leds: Fix warnings when PM is disabled for BD2802 Mark Brown
2011-01-21 22:14 ` Andrew Morton
2011-01-21 23:38 ` Dmitry Torokhov
2011-01-21 23:47 ` Mark Brown
2011-01-22 10:21 ` Rafael J. Wysocki
2011-01-22 0:23 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121162325.c3b513bf.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox