From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: "Dr. David Alan Gilbert" <david.gilbert@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mingo@elte.hu,
dave.martin@linaro.org
Subject: Re: [PATCH] fix perf Annotation of Thumb code
Date: Fri, 21 Jan 2011 15:40:55 -0200 [thread overview]
Message-ID: <20110121174055.GD15066@ghostprotocols.net> (raw)
In-Reply-To: <4D39BF9E.3030007@ru.mvista.com>
Em Fri, Jan 21, 2011 at 08:17:18PM +0300, Sergei Shtylyov escreveu:
> >(For reference this corresponds to this bug
> >https://bugs.launchpad.net/linux-linaro/+bug/677547 )
>
> > Signed-off-by: Dr. David Alan Gilbert <david.gilbert@linaro.org>
>
> Hm, I think there should be no spaces/tabs before signoff...
>
> >+ sym.st_value-=1;
>
> The coding style used suggests spaces around -=.
>
> WBR, Sergei
I noticed both issues and will fix them up when applying the patch.
Thanks
- Arnaldo
next prev parent reply other threads:[~2011-01-21 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 16:40 [PATCH] fix perf Annotation of Thumb code Dr. David Alan Gilbert
2011-01-21 17:13 ` Arnaldo Carvalho de Melo
2011-01-21 17:17 ` Sergei Shtylyov
2011-01-21 17:40 ` Arnaldo Carvalho de Melo [this message]
2011-01-21 17:50 ` David Gilbert
2011-01-22 15:19 ` [tip:perf/urgent] perf symbols: Fix annotation of thumb code tip-bot for Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121174055.GD15066@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dave.martin@linaro.org \
--cc=david.gilbert@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox