From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752998Ab1AUUq2 (ORCPT ); Fri, 21 Jan 2011 15:46:28 -0500 Received: from kroah.org ([198.145.64.141]:38336 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752684Ab1AUUq0 (ORCPT ); Fri, 21 Jan 2011 15:46:26 -0500 Date: Fri, 21 Jan 2011 12:33:52 -0800 From: Greg KH To: Sutharsan Ramamoorthy Cc: tony@atomide.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-usb@vger.kernel.org, david.cross@cypress.com, srmt@cypress.com Subject: Re: [PATCH] Westbridge software module, fixes errors reported by checkpatch.pl Message-ID: <20110121203352.GD22299@kroah.com> References: <444938.26253.qm@web121610.mail.ne1.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <444938.26253.qm@web121610.mail.ne1.yahoo.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 19, 2011 at 05:31:46PM -0800, Sutharsan Ramamoorthy wrote: > From: Sutharsan Ramamoorthy > > This patch fixes errors in westbridge device controller driver in the > staging tree reported by checkpatch.pl. File containing EXPORT_SYMBOL() > macros for all the APIs exported by the westbridge software has been removed. EXPORT_SYMBOL() macros are added after the corresponding function definitions. In the future, please wrap your commit messages at 72 characters, so I don't have to edit the patch by hand. Your subject was also quite vague, I've fixed it up, please be more careful in the future. thanks, greg k-h