From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754909Ab1AUXy0 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 21 Jan 2011 18:54:26 -0500
Received: from mail-gy0-f174.google.com ([209.85.160.174]:57819 "EHLO
	mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754178Ab1AUXyZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 21 Jan 2011 18:54:25 -0500
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-type:content-disposition:in-reply-to:user-agent;
        b=DDpKTI27sJVcY79ayx5Jx717/Wbt0aH/itfbsPwP2Z6G4JErTMPUXwX4nOCEmnVKpO
         I1Kpy5dHCkZ4gvP6mGlnRsNK784ZUX/2/hX9I1WOZPT7DCRNNgNqUTxCMNFiyoZ+kw+/
         yAYhtiz1SReQQvrOjv5hneenZ/2oY9ay/N5S8=
Date: Sat, 22 Jan 2011 08:54:13 +0900
From: Minchan Kim <minchan.kim@gmail.com>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Christoph Lameter <cl@linux.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>,
        Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH 1/3] When migrate_pages returns 0, all pages must have
 been released
Message-ID: <20110121235413.GA1703@barrios-desktop>
References: <f60d811fd1abcb68d40ac19af35881d700a97cd2.1295539829.git.minchan.kim@gmail.com>
 <alpine.DEB.2.00.1101201130100.10695@router.home>
 <20110120182444.GA9506@random.random>
 <alpine.DEB.2.00.1101201233001.20633@router.home>
 <20110120212841.GB9506@random.random>
 <alpine.DEB.2.00.1101211005150.14313@router.home>
 <20110121173618.GH9506@random.random>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20110121173618.GH9506@random.random>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 21, 2011 at 06:36:18PM +0100, Andrea Arcangeli wrote:
> On Fri, Jan 21, 2011 at 10:11:03AM -0600, Christoph Lameter wrote:
> > On Thu, 20 Jan 2011, Andrea Arcangeli wrote:
> > 
> > > Which following putback_lru_page()?  You mean
> > > putback_lru_page(newpage)? That is for the newly allocated page
> > > (allocated at the very top, so always needed), it's not relevant to
> > > the page_count(page) = 1. The page_count 1 is hold by the caller, so
> > > it's leaking memory right now (for everything but compaction).
> > 
> > Ahh yes we removed the putback_lru_pages call from migrate_pages()
> > and broke the existing release logic. The caller has to call
> > putback_release_pages() as per commit
> 
> putback_lru_paeges
> 
> > cf608ac19c95804dc2df43b1f4f9e068aa9034ab
> 
> That is the very commit that introduced the two bugs that I've fixed
> by code review.
> 
> > 
> > If that is still the case then we still have the double free.
> 
> The caller only calls putback_lru_pages if ret != 0 (the two cases you
> refer to happen with ret = 0).
> 
> Even if caller unconditionally calls putback_lru_pages (kind of what
> compaction did), it can't double free because migrate_pages already
> unlinked the pages before calling putback_lru_page(page), so there's
> no way to do a double free (however if the caller unconditionally
> called putback_lru_pages there would be no memleak to fix, but it
> doesn't).
> 
> > Could we please document the calling conventions exactly in the source?
> > Right now it says that the caller should call putback_lru_pages().
> 
> The caller should call putback_lru_pages only if ret != 0. Minchan
> this is your commit we're discussing can you check the commentary?

No problem.
I will send the patch.

Thanks Adnrea, Christoph.


> 
> Thanks!
> Andrea
> 

-- 
Kind regards,
Minchan Kim